Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

dhcp server unit file is changed to disabled after upgrade #826

Closed
brianjmurrell opened this issue Jan 30, 2022 · 1 comment · Fixed by #1060
Closed

dhcp server unit file is changed to disabled after upgrade #826

brianjmurrell opened this issue Jan 30, 2022 · 1 comment · Fixed by #1060
Labels
bug Something isn't working

Comments

@brianjmurrell
Copy link
Contributor

Actual behavior
dhcp is replaced by dhcp-server which turns a previously enabled service unit off with no mention of it whatsoever in /var/log/leapp/leapp-report.txt.

To Reproduce
Probably pretty obvious. Let me know if it's not.

Expected behavior
If one package replaces another, which results in the systemd unit file changing which results in a previously enabled service being disabled after the upgrade, the least that should be done is a mention of the situation in the report. I would argue that more should be done and that the replacing unit should be set to the same state as the replaced unit so that post-upgrade, service continues as it was before upgrade.

System information (please complete the following information):

  • OS and version: CentOS 7.9
  • Linux server.interlinx.bc.ca 3.10.0-1160.49.1.el7.x86_64 #1 SMP Tue Nov 30 15:51:32 UTC 2021 x86_64 x86_64 x86_64 GNU/Linux
  • leapp-0.12.1-100.20210924142320684911.master.28.g1f03432.el7.noarch
    leapp-upgrade-el7toel8-deps-0.14.0-100.202109271224Z.b7ebfca.master.el7.elevate.noarch
    leapp-upgrade-el7toel8-0.14.0-100.202109271224Z.b7ebfca.master.el7.elevate.noarch
    leapp-deps-0.12.1-100.20210924142320684911.master.28.g1f03432.el7.noarch
    python2-leapp-0.12.1-100.20210924142320684911.master.28.g1f03432.el7.noarch
    leapp-data-almalinux-0.1-2.el7.noarch

Happy to provide further information if anything here is ambiguous or unclear.
@brianjmurrell brianjmurrell added the bug Something isn't working label Jan 30, 2022
@pirat89
Copy link
Member

pirat89 commented Mar 7, 2023

Hi \o I am sorry for the late response. Thanks for the feedback. We know about several related issues. Currently, we have delivered in the first iteration fixes for services with broken symlinks (caused e.g. by changed name of the rpm) and for the next one we plan to deliver the general hangling of systemd services, so e.g. dhcp should be covered by that (unless it's already covered by previous fixes). pinnning the issue (@matejmatuska fyi)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants