Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

orderless-filter - remove condition-case for invalid-regexp #43

Closed
minad opened this issue Mar 23, 2021 · 1 comment
Closed

orderless-filter - remove condition-case for invalid-regexp #43

minad opened this issue Mar 23, 2021 · 1 comment

Comments

@minad
Copy link
Collaborator

minad commented Mar 23, 2021 •
edited
Loading

Does it make sense to remove the condition-case since this should never happen? I think it is better to remove it then, since it could potentially shadow other bugs. Basically the pattern compiler should never produce invalid regexps. See 237ee00.
@minad
Copy link
Collaborator Author

minad commented Mar 23, 2021

Fixed in #44

@minad minad closed this as completed Mar 23, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@minad