[VL] feat: support partial merge phase in aggregation #1330
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for opening a pull request! Could you open an issue for this pull request on Github Issues? https://github.com/oap-project/gluten/issues Then could you also rename commit message and pull request title in the following format? See also: |
rui-mo
commented
Apr 11, 2023
| structTypeNodes.add(ConverterUtils.getTypeNode(DoubleType, nullable = true)) | ||
| structTypeNodes.add(ConverterUtils.getTypeNode(LongType, nullable = true)) | ||
| structTypeNodes.add(ConverterUtils.getTypeNode(DoubleType, nullable = true)) | ||
| structTypeNodes.add(ConverterUtils.getTypeNode(DoubleType, nullable = true)) |
There was a problem hiding this comment.
Hi @liujiayi771, could you help review this change? Eight intermediate types were used here, but looks to me only four is needed.
There was a problem hiding this comment.
Only need four, It should be that a rebase has retained the wrong code.
There was a problem hiding this comment.
Got it. Thanks for checking.
rui-mo
force-pushed
the
wip_part_merge
branch
3 times, most recently
from
8a41884
to
c0d5893
Compare
zhouyuan
previously approved these changes
Apr 14, 2023
PHILO-HE
approved these changes
Apr 14, 2023
|
Thanks for your review! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Support partial merge phase on Velox backend. This PR mainly focuses on supporting the partial merge step brings by
count distinct, and a follow-up PR will be proposed to support other distinct functions.oap-project/velox#193
How was this patch tested?
Verified on Jenkins.