Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add postback support #6

Merged
merged 9 commits into from
Jan 16, 2017
Merged

Add postback support #6

merged 9 commits into from
Jan 16, 2017

Conversation

makefunstuff
Copy link
Collaborator

@makefunstuff makefunstuff commented Dec 17, 2016 •
edited
Loading

Details

Currently work in progress postback support.
The goal is to support all possible webhook payloads provided by messenger api.

TODO:

  • Add more tests

  • Provide usage examples with postback

  • fix coverage issues

@coveralls
Copy link

coveralls commented Dec 17, 2016 •
edited
Loading

Coverage Status

Coverage decreased (-5.7%) to 91.538% when pulling 09de56a on strangeworks:add-postback-support into 7c1b859 on oarrabi:master.

1 similar comment
@coveralls
Copy link

Coverage Status

Coverage decreased (-5.7%) to 91.538% when pulling 09de56a on strangeworks:add-postback-support into 7c1b859 on oarrabi:master.

@coveralls
Copy link

coveralls commented Dec 17, 2016 •
edited
Loading

Coverage Status

Coverage decreased (-5.7%) to 91.538% when pulling 2d9bdae on strangeworks:add-postback-support into 7c1b859 on oarrabi:master.

@coveralls
Copy link

coveralls commented Dec 17, 2016 •
edited
Loading

Coverage Status

Coverage decreased (-5.2%) to 92.086% when pulling 09de56a on strangeworks:add-postback-support into 7c1b859 on oarrabi:master.

@coveralls
Copy link

coveralls commented Dec 17, 2016 •
edited
Loading

Coverage Status

Coverage decreased (-5.7%) to 91.538% when pulling 7d8afd2 on strangeworks:add-postback-support into 7c1b859 on oarrabi:master.

@coveralls
Copy link

Coverage Status

Coverage decreased (-5.9%) to 91.304% when pulling 79eeb6e on strangeworks:add-postback-support into 7c1b859 on oarrabi:master.

2 similar comments
@coveralls
Copy link

Coverage Status

Coverage decreased (-5.9%) to 91.304% when pulling 79eeb6e on strangeworks:add-postback-support into 7c1b859 on oarrabi:master.

@coveralls
Copy link

Coverage Status

Coverage decreased (-5.9%) to 91.304% when pulling 79eeb6e on strangeworks:add-postback-support into 7c1b859 on oarrabi:master.

@coveralls
Copy link

coveralls commented Dec 25, 2016 •
edited
Loading

Coverage Status

Coverage decreased (-13.3%) to 83.942% when pulling 86f0398 on strangeworks:add-postback-support into 7c1b859 on oarrabi:master.

1 similar comment
@coveralls
Copy link

Coverage Status

Coverage decreased (-13.3%) to 83.942% when pulling 86f0398 on strangeworks:add-postback-support into 7c1b859 on oarrabi:master.

@coveralls
Copy link

Coverage Status

Coverage decreased (-5.4%) to 91.852% when pulling e0abe23 on strangeworks:add-postback-support into 7c1b859 on oarrabi:master.

2 similar comments
@coveralls
Copy link

Coverage Status

Coverage decreased (-5.4%) to 91.852% when pulling e0abe23 on strangeworks:add-postback-support into 7c1b859 on oarrabi:master.

@coveralls
Copy link

Coverage Status

Coverage decreased (-5.4%) to 91.852% when pulling e0abe23 on strangeworks:add-postback-support into 7c1b859 on oarrabi:master.

@coveralls
Copy link

Coverage Status

Coverage decreased (-5.4%) to 91.852% when pulling 68bbf3b on strangeworks:add-postback-support into 7c1b859 on oarrabi:master.

2 similar comments
@coveralls
Copy link

Coverage Status

Coverage decreased (-5.4%) to 91.852% when pulling 68bbf3b on strangeworks:add-postback-support into 7c1b859 on oarrabi:master.

@coveralls
Copy link

Coverage Status

Coverage decreased (-5.4%) to 91.852% when pulling 68bbf3b on strangeworks:add-postback-support into 7c1b859 on oarrabi:master.

@makefunstuff makefunstuff mentioned this pull request Jan 16, 2017
Closed
@makefunstuff makefunstuff changed the title WIP: Add postback support Add postback support Jan 16, 2017
nsomar
nsomar reviewed Jan 16, 2017
View reviewed changes
README.md
def message(msg) do
text = FacebookMessenger.Response.message_texts(msg) |> hd
sender = FacebookMessenger.Response.message_senders(msg) |> hd
def message(msg) d
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

typo here, i guess its should be do

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

good point, thanks

@coveralls
Copy link

coveralls commented Jan 16, 2017 •
edited
Loading

Coverage Status

Coverage decreased (-5.4%) to 91.852% when pulling 65d7c6b on strangeworks:add-postback-support into 7c1b859 on oarrabi:master.

@coveralls
Copy link

coveralls commented Jan 16, 2017 •
edited
Loading

Coverage Status

Coverage decreased (-5.5%) to 91.791% when pulling 8ee9684 on strangeworks:add-postback-support into 7c1b859 on oarrabi:master.

@nsomar
Copy link
Owner

nsomar commented Jan 16, 2017

@strangeworks awesome!! merging!

@nsomar nsomar merged commit f75e022 into nsomar:master Jan 16, 2017
@makefunstuff makefunstuff deleted the add-postback-support branch January 16, 2017 21:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nsomar nsomar nsomar left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@makefunstuff @coveralls @nsomar