Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Helper functions for DT #39

Closed
oashour opened this issue Nov 1, 2020 · 2 comments
Closed

Helper functions for DT #39

oashour opened this issue Nov 1, 2020 · 2 comments

Comments

@oashour
Copy link
Owner

oashour commented Nov 1, 2020 •
edited
Loading

Helper functions and utilities/QoL changes should include:

  1. A way to set the number of x nodes directly in Box, instead of being forced to set dx, which doesn't make too much sense for DT.

  2. Extend the function compute_params to compute all the relevant parameters as currently done in the constructor of calc. This will add modularity and make life easier for other functions.
@oashour
Copy link
Owner Author

oashour commented Nov 1, 2020

  1. Implemented in 6dcbaa0

@oashour
Copy link
Owner Author

oashour commented Feb 8, 2021

  1. Is currently unnecessary, I would like to keep computte_params as part of the public API for usage with breathers.

@oashour oashour closed this as completed Feb 8, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@oashour