Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bad Pattern for Binary Literals #43

Closed
varnerac opened this issue Dec 14, 2017 · 4 comments
Closed

Bad Pattern for Binary Literals #43

varnerac opened this issue Dec 14, 2017 · 4 comments
Labels
bug
Milestone
1.0

Comments

@varnerac
Copy link

From latest pip installed version:

Enter a pattern to validate: [ qq  : dt  . DI   NOt < b'====']              

PASS: [ qq  : dt  . DI   NOt < b'====']

==== is not a valid Base64 literal
@gtback
Copy link
Contributor

gtback commented Jan 10, 2018

Thanks, @varnerac. We'll have to see the best way to fix this.

@gtback
Copy link
Contributor

gtback commented Feb 26, 2018

The definition for BinaryLiteral in the grammar needs to be updated to account for this.

@gtback gtback added this to the 1.0 milestone Feb 26, 2018
This was referenced Mar 9, 2018
Merged
Merged
@gtback
Copy link
Contributor

gtback commented Mar 12, 2018

@varnerac This should be fixed now, but if not, feel free to reopen.

@varnerac
Copy link
Author

LGTM

@gtback gtback added the bug label Jun 12, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug
Projects
None yet
Milestone
1.0
Development

No branches or pull requests
2 participants
@gtback @varnerac