Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Custom properties not added when using allow_custom=True #98

Closed
emmanvg opened this issue Nov 2, 2017 · 4 comments · Fixed by #100
Closed

Custom properties not added when using allow_custom=True #98

emmanvg opened this issue Nov 2, 2017 · 4 comments · Fixed by #100
Assignees
@emmanvg
Labels
bug
Milestone
0.4

Comments

@emmanvg
Copy link
Contributor

emmanvg commented Nov 2, 2017

No description provided.

@emmanvg
Copy link
Contributor Author

emmanvg commented Nov 2, 2017

When using allow_custom=True, the new custom properties don't get added to the _properties dictionary. *This is not related to CustomObject.

@gtback
Copy link
Contributor

gtback commented Nov 2, 2017

Shouldn't _properties be a class-level variable? We wouldn't want to modify that. Also, do you mean the Property subclasses, or the values of the properties.

@gtback gtback added this to the 0.4 milestone Nov 2, 2017
@emmanvg
Copy link
Contributor Author

emmanvg commented Nov 2, 2017

It's the _properties dict on _STIXBase. This issue only appears on Python 3 and it is related to #85.

@emmanvg
Copy link
Contributor Author

emmanvg commented Nov 2, 2017 •
edited

That was the reason I had to change object_properties(), but the underlining behavior problem was not solved. This being, to add custom properties to the _properties dict. While talking to @clenk I noticed the problem was still there.

@emmanvg emmanvg self-assigned this Nov 2, 2017
This was referenced Nov 2, 2017
Closed
Merged
@gtback gtback added the bug label Jun 18, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@emmanvg emmanvg

Labels
bug
Projects
None yet
Milestone
0.4
Development

Successfully merging a pull request may close this issue.

Performance, Design and other fixes emmanvg/cti-python-stix2
2 participants
@gtback @emmanvg