Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Independent library for Javascript module #42

Open
capy-pl opened this issue Mar 18, 2019 · 7 comments
Open

Independent library for Javascript module #42

capy-pl opened this issue Mar 18, 2019 · 7 comments

Comments

@capy-pl
Copy link

capy-pl commented Mar 18, 2019

Is there any plan for creating an independent library to seperate the js module from other parts? Or consider adding a package.json so user can install the project by using npm install.

@clenk
Copy link
Contributor

clenk commented May 24, 2019

Hi, @capy-pl, sorry for the delay in responding. We aren't currently working on this, but it would be a good feature and we'd welcome a pull request if anyone had time to do it. :)

@dwjohnston
Copy link

@clenk I may take a look at this.

I think the question I have is, what's the purpose of the python code in this repo?

@clenk
Copy link
Contributor

clenk commented Mar 28, 2022

Hi @dwjohnston thanks for the interest. The python code is used to enable visualizing STIX content inside Jupyter notebooks. More info here. The STIX generator uses it for this purpose.

@dwjohnston
Copy link

dwjohnston commented Mar 29, 2022

@clenk with the dependencies that you have copied in here:

  • requirejs
  • d3

Have those been modified in any way?

Also, looks like d3 version is 3.5.14 - I should assume that ^3 is the only supported version?

@dwjohnston
Copy link

@clenk Alright man - take a look at the PR.

For testing on your side:

  • Follow the 'local use' instructions to see that your existing example use (the index.html) still works
  • This repo here demonstrates use of it as a package: https://github.com/dwjohnston/stix-vis-test
  • Can you check that it still works with Jupyter?

@clenk
Copy link
Contributor

clenk commented Mar 29, 2022

Thanks @dwjohnston I'll take a look when I get the chance. The dependencies have not been modified in any way.

For d3, we've been looking into upgrading it and actually are looking at switching to Apache ECharts.

@dwjohnston
Copy link

dwjohnston commented Mar 29, 2022

Thanks @dwjohnston I'll take a look when I get the chance. The dependencies have not been modified in any way.

For d3, we've been looking into upgrading it and actually are looking at switching to Apache ECharts.

Ooh, that reminds me - probably should update the PR to remove the hardcoded d3.js and instead refer to one in the node modules. (Otherwise the published NPM package, the use in Jupyter/local may be different).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants