Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Member has a member_id which is not its ID #66

Closed
jmccrae opened this issue Dec 12, 2023 · 2 comments · Fixed by #75
Closed

Member has a member_id which is not its ID #66

jmccrae opened this issue Dec 12, 2023 · 2 comments · Fixed by #75
Assignees
@michmech
Labels
module affects only modules
Milestone
1st public review

Comments

@jmccrae
Copy link
Contributor

jmccrae commented Dec 12, 2023

This property's name is confusing. Can we change it to something like ref to indicate it is the reference not the ID of the member?

Issue arose during implementation of #61
@jmccrae jmccrae added the module affects only modules label Dec 12, 2023
@jmccrae jmccrae added this to the 1st public review milestone Dec 12, 2023
@DavidFatDavidF
Copy link
Contributor

Rename "member_id" to "ref" and make clear that it references objects, referencing mechanism is serialization specific
@michmech to implement by January 3, 2024

@jmccrae jmccrae mentioned this issue Jan 1, 2024
Merged
@michmech michmech mentioned this issue Jan 4, 2024
Merged
@michmech
Copy link
Contributor

michmech commented Jan 4, 2024

  • Done at model level
  • Done in serializations
  • Done in the “Examples” section

Will close automatically when pull request #75 is merged.

@jmccrae jmccrae mentioned this issue Mar 6, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@michmech michmech

Labels
module affects only modules
Projects
None yet
Milestone
1st public review
Development

Successfully merging a pull request may close this issue.

Implementing decisions taken on 20 Dec 2023 michmech/lexidma
3 participants
@jmccrae @DavidFatDavidF @michmech