Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

obverseListingOrder is mandatory but missing in examples #67

Closed
jmccrae opened this issue Dec 12, 2023 · 3 comments · Fixed by #75
Closed

obverseListingOrder is mandatory but missing in examples #67

jmccrae opened this issue Dec 12, 2023 · 3 comments · Fixed by #75
Assignees
@michmech
Labels
bug Something isn't working module affects only modules
Milestone
1st public review

Comments

@jmccrae
Copy link
Contributor

jmccrae commented Dec 12, 2023

The property obverseListingOrder is mandatory for members but is not used in examples.

I think this should probably not be mandatory

Issue blocks implementation of #61
@jmccrae jmccrae added bug Something isn't working module affects only modules labels Dec 12, 2023
@jmccrae jmccrae added this to the 1st public review milestone Dec 12, 2023
@jmccrae
Copy link
Contributor Author

jmccrae commented Dec 20, 2023

Make obverseListingOrder optional (agreed 20/12)

@DavidFatDavidF
Copy link
Contributor

@michmech to implement by January 3, 2024

@jmccrae jmccrae mentioned this issue Jan 1, 2024
Merged
@michmech michmech mentioned this issue Jan 4, 2024
Merged
@michmech
Copy link
Contributor

michmech commented Jan 4, 2024

  • Done at model level
  • Done in serializations

Will close automatically when pull request #75 is merged.

@jmccrae jmccrae mentioned this issue Mar 6, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@michmech michmech

Labels
bug Something isn't working module affects only modules
Projects
None yet
Milestone
1st public review
Development

Successfully merging a pull request may close this issue.

Implementing decisions taken on 20 Dec 2023 michmech/lexidma
3 participants
@jmccrae @DavidFatDavidF @michmech