Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Suggestion: Support tool plug-ins #207

Closed
ghost opened this issue Jul 25, 2018 · 3 comments
Closed

Suggestion: Support tool plug-ins #207

ghost opened this issue Jul 25, 2018 · 3 comments

Comments

@ghost
Copy link

ghost commented Jul 25, 2018

Suppose you have an analysis tool MyTool.exe that accepts plug-ins, for example ContosoSecurityRules.dll. SARIF has no way to specify the versions of the plug-ins that the tool is using.

Worse than that: if your tool specifies plug-ins on the command line, then at least they'll show up in the invocation.commandLine property. But of your tool finds plug-ins by looking in a well-known directory, then they won't be on the command line, and even the names of the plug-ins won't appear in the SARIF file.

Proposal:
Define a plugIn object with properties fileLocation (of type fileLocation) and version (of type string). Give tool a new property plugIns of type "array of plugIn".

@ghost
Copy link
Author

ghost commented Jul 25, 2018

Probably the plugIn object would have the same set of versioning properties that tool does: version, semanticVersion, and fileVersion (but not sarifLoggerVersion).

@michaelcfanning
Copy link
Contributor

@lgolding this is a duplicate of #179, can we close this one or the other?

@ghost
Copy link
Author

ghost commented Aug 24, 2018

@michaelcfanning Yes, it is a duplicate. I'll close this one, and paste the specific proposals I made here into #179.

This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant