Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Each redaction token in an originalUriBaseId represents a unique location. #377

Closed
ghost opened this issue Apr 15, 2019 · 2 comments
Closed
Labels
2.1.0-CSD.1 Will be fixed in SARIF v2.1.0 CSD.1. design-improvement resolved-wont-fix

Comments

@ghost
Copy link

ghost commented Apr 15, 2019

From @kupsch, regarding p.29 3.4.5 (artifactLocation.)index property:

There should be a mechanism to redact multiple uriBaseIds, but still allow them to be different directories in the file system. If the redactionToken is used then there needs to be a note that if the redactionToken is present in segment, then each use within a uri should be considered a unique (undisclosed) location in the file system, just like a uri with "..". If the redactionToken appears in a uriBaseId's uri, then the uriBaseId should be treated as if it were a unique (undisclosed) directory location, but all uses of the that uriBaseId with the redacted segment should be considered to have the same unique (undisclosed) path prefix. For instance if the redactionToken is "[REDACTED]", and a uriBaseId named X has a uri of "[REDACTED]", then { uriBaseId = "X", uri = "f.c"} and { uriBaseId = "X", uri = "f.c"} are the same path, whereas { uri = "[REDACTED]/f.c } and { uri = "[REDACTED]/f.c } should not be considered the same path.

@ghost ghost added 2.1.0-CSD.1 Will be fixed in SARIF v2.1.0 CSD.1. design-improvement labels Apr 15, 2019
@ghost ghost self-assigned this Apr 15, 2019
@ghost ghost mentioned this issue Apr 15, 2019
@ghost ghost changed the title Each redaction token in an originalUriBaseId is a represents a unique location. Each redaction token in an originalUriBaseId represents a unique location. Apr 16, 2019
@michaelcfanning
Copy link
Contributor

TC approves this change:

Replace run.redactionToken, a string with run.redactionTokens, an array of strings.

@ghost
Copy link
Author

ghost commented Apr 26, 2019

Closing because we have decided we cannot let URIs be redactable -- badly breaks the SDK.

@ghost ghost closed this as completed Apr 26, 2019
@ghost ghost added the resolved-wont-fix label Apr 26, 2019
This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
2.1.0-CSD.1 Will be fixed in SARIF v2.1.0 CSD.1. design-improvement resolved-wont-fix
Projects
None yet
Development

No branches or pull requests

1 participant