Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Write an Appendix on how a consumer decides if a run has failed #398

Closed
ghost opened this issue Apr 26, 2019 · 0 comments
Closed

Write an Appendix on how a consumer decides if a run has failed #398

ghost opened this issue Apr 26, 2019 · 0 comments
Labels
2.1.0-CSD.1 Will be fixed in SARIF v2.1.0 CSD.1. impact-non-breaking-change merged Changes merged into provisional draft. non-substantive Change falls under editorial discretion resolved-fixed

Comments

@ghost
Copy link

ghost commented Apr 26, 2019

@michaelcfanning suggested we add an Appendix that explains how a consumer can look at a log file and decide that the results are useful and complete. Some possible answers are:

  • invocation.toolExecutionSuccessful is true for all elements of run.invocations,
  • There are no toolExecutionNotifications or toolConfigurationNotifications in any invocation object whose level is "error",
  • run.results is non-null.

Actually that's a pretty darned short appendix. Perhaps I can find another place for this useful information.

@ghost ghost self-assigned this Apr 26, 2019
@ghost ghost added 2.1.0-CSD.1 Will be fixed in SARIF v2.1.0 CSD.1. non-substantive Change falls under editorial discretion and removed non-substantive Change falls under editorial discretion labels Apr 26, 2019
@ghost ghost added resolved-fixed merged Changes merged into provisional draft. and removed to-be-written labels May 16, 2019
@ghost ghost closed this as completed May 20, 2019
This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
2.1.0-CSD.1 Will be fixed in SARIF v2.1.0 CSD.1. impact-non-breaking-change merged Changes merged into provisional draft. non-substantive Change falls under editorial discretion resolved-fixed
Projects
None yet
Development

No branches or pull requests

0 participants