Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rename invocation.toolExecutionSuccessful to executionSuccessful #399

Closed
ghost opened this issue Apr 26, 2019 · 1 comment
Closed

Rename invocation.toolExecutionSuccessful to executionSuccessful #399

ghost opened this issue Apr 26, 2019 · 1 comment
Labels
2.1.0-CSD.1 Will be fixed in SARIF v2.1.0 CSD.1. design-improvement impact-breaks-consumers impact-breaks-producers merged Changes merged into provisional draft. resolved-fixed

Comments

@ghost
Copy link

ghost commented Apr 26, 2019 •
edited by ghost
Loading

@kupsch points out that if SARIF is enhanced in future to support dynamic analysis tools, we could reuse the invocation object to describe the invocation of the program under test. In that case, executionSuccessful would be a more appropriate name than toolExecutionSuccessful. @michaelcfanning and I agree that this inexpensive bit of future-proofing is worth taking.

It's true that toolExecutionNotifications and toolConfigurationNotifications wouldn't apply in that scenario. But OTOH, they would not appear in the log file in that scenario, so no harm would be done. And this rename at least eliminates a gratuitous inconsistency with that scenario.
@ghost ghost self-assigned this Apr 26, 2019
@ghost ghost added 2.1.0-CSD.1 Will be fixed in SARIF v2.1.0 CSD.1. design-improvement impact-breaks-consumers impact-breaks-producers schema-todo merged Changes merged into provisional draft. resolved-fixed labels Apr 26, 2019
@ghost ghost closed this as completed Apr 26, 2019
@ghost ghost removed the schema-todo label Apr 29, 2019
@ghost
Copy link
Author

ghost commented Apr 29, 2019

I confirm that this change is correctly in the schema.

This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
2.1.0-CSD.1 Will be fixed in SARIF v2.1.0 CSD.1. design-improvement impact-breaks-consumers impact-breaks-producers merged Changes merged into provisional draft. resolved-fixed
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
0 participants