Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Change location.logicalLocation to logicalLocations array #414

Closed
ghost opened this issue May 15, 2019 · 2 comments
Closed

Change location.logicalLocation to logicalLocations array #414

ghost opened this issue May 15, 2019 · 2 comments
Labels
2.1.0-CSD.1 Will be fixed in SARIF v2.1.0 CSD.1. enhancement impact-breaks-consumers impact-breaks-producers merged Changes merged into provisional draft. resolved-fixed

Comments

@ghost
Copy link

ghost commented May 15, 2019

There are cases where you can express a logical location in more than one way. For example, in HTML you can express the location of an element as an XPath (/body/para[1]/img[1]) or as a CSS selector (#logo). We'd like to be able to mention both.
@ghost ghost changed the title Change result.logicalLocations to logicalLocations array Change result.logicalLocation to logicalLocations array May 15, 2019
@ghost
Copy link
Author

ghost commented May 15, 2019

This is for the future.

@ghost ghost closed this as completed May 15, 2019
@ghost ghost self-assigned this May 17, 2019
@ghost
Copy link
Author

ghost commented May 20, 2019

Not for the future after all.

@ghost ghost closed this as completed May 20, 2019
@ghost ghost added the merged Changes merged into provisional draft. label May 20, 2019
@ghost ghost changed the title Change result.logicalLocation to logicalLocations array Change location.logicalLocation to logicalLocations array May 20, 2019
This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
2.1.0-CSD.1 Will be fixed in SARIF v2.1.0 CSD.1. enhancement impact-breaks-consumers impact-breaks-producers merged Changes merged into provisional draft. resolved-fixed
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@michaelcfanning