Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Editorial issue in invocation.startTimeUtc and invocation.endTimeUtc descriptions #445

Closed
michaelcfanning opened this issue Dec 23, 2019 · 2 comments
Closed

Editorial issue in invocation.startTimeUtc and invocation.endTimeUtc descriptions #445

michaelcfanning opened this issue Dec 23, 2019 · 2 comments
Labels
2.1.0-candidate-standard-TC-comment Comment submitted by TC member during 60-day OASIS Candidate Standard comment period for SARIF 2.1.0 resolved-fixed

Comments

@michaelcfanning
Copy link
Contributor

michaelcfanning commented Dec 23, 2019 •
edited

As below the descriptions for invocation.startTimeUtc and invocation.endTimeUtc should refer to the invocation and not the run instance. This correction was likely missed when we created the notion of multiple invocations to represent a single run (moving the relevant UTC properties to the invocation type).

"description": "The Coordinated Universal Time (UTC) date and time at which the run started

@lgolding, FYI
@michaelcfanning
Copy link
Contributor Author

We may consider updating descriptions for the invocation machine, processId and workingDirectory descriptions as well.

@ghost ghost self-assigned this Dec 25, 2019
@ghost ghost added the 2.1.0-candidate-standard-TC-comment Comment submitted by TC member during 60-day OASIS Candidate Standard comment period for SARIF 2.1.0 label Dec 25, 2019
@ghost
Copy link

ghost commented Feb 21, 2020

@michaelcfanning executableLocation also needed tweaking.

@ghost ghost added the resolved-fixed label Feb 21, 2020
@ghost ghost closed this as completed Feb 21, 2020
This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
2.1.0-candidate-standard-TC-comment Comment submitted by TC member during 60-day OASIS Candidate Standard comment period for SARIF 2.1.0 resolved-fixed
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@michaelcfanning