Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

virtio-net: Fix and update VIRTIO_NET_F_NOTF_COAL feature #159

Closed
Alvaro-Karsz opened this issue Feb 6, 2023 · 1 comment
Closed

virtio-net: Fix and update VIRTIO_NET_F_NOTF_COAL feature #159

Alvaro-Karsz opened this issue Feb 6, 2023 · 1 comment

Comments

@Alvaro-Karsz
Copy link
Contributor

Alvaro-Karsz commented Feb 6, 2023

Make several improvements to the notification coalescing feature, including:

  • Consolidating virtio_net_ctrl_coal_tx and virtio_net_ctrl_coal_rx
    into a single struct, virtio_net_ctrl_coal, as they are identical.
  • Emphasizing that the coalescing commands are best-effort.
  • Defining the behavior of coalescing with regards to delivering
    notifications when a change occur.
  • Stating that the commands should apply to all the receive/transmit
    virtqueues.
  • Stating that every receive/transmit virtqueue should count it's own
    packets.
  • A new intro explaining the entire coalescing operation.

https://lists.oasis-open.org/archives/virtio-comment/202302/msg00431.html

@mstsirkin
Copy link
Contributor

BALLOT CREATED AT URL: https://www.oasis-open.org/committees/ballot.php?id=3760

@cohuck cohuck closed this as completed in 73ce5bb Mar 1, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants