Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Inclusion in F-Droid #10

Closed
Poussinou opened this issue Nov 21, 2018 · 22 comments
Closed

Inclusion in F-Droid #10

Poussinou opened this issue Nov 21, 2018 · 22 comments

Comments

@Poussinou
Copy link

Hi,

Since this app is Apache v2 licensed, are you considering the fact to add it to F-Droid? There is a strong community behind.

You can find some documentation here.

Otherwise, if you don't want to work on the inclusion of this app by yourself, would it be ok for you if someone else do it for you?

@oasisfeng
Copy link
Owner

I'm afraid Island may not be qualified for F-Droid, as closed-source libraries (e.g. Firebase) are used.

@Poussinou
Copy link
Author

Well I wasn't aware of the use of Firebase because it's not written in the gradle file I checked but in the other one.

Could you instead provide an apk with each release in the corresponding section here on Github?

@oasisfeng
Copy link
Owner

I have plan to do that, but need a bit of work to build the CI environment. Before that, you can download the APKs here: https://www.dropbox.com/sh/3fmjigfejcu0kko/AABJy7du0DQx2Jn_R0uQcy6Ea?dl=0

@Poussinou
Copy link
Author

Thanks a lot 👍

Looking forward for the apks in the release section, since it's a lot easier to update ;)

@oasisfeng
Copy link
Owner

APK is already included for recent releases.

@smnthermes
Copy link

You could make a gradle build exclusively for F-Droid, perhaps with an alternative analytics provider

@smnthermes
Copy link

@oasisfeng

@oasisfeng
Copy link
Owner

You could make a gradle build exclusively for F-Droid, perhaps with an alternative analytics provider

No plan for that yet.

@cognition9144
Copy link

cognition9144 commented Apr 20, 2020

You could make a gradle build exclusively for F-Droid, perhaps with an alternative analytics provider

No plan for that yet.

Will it be acceptable if I issue a PR?

@oasisfeng
Copy link
Owner

You could make a gradle build exclusively for F-Droid, perhaps with an alternative analytics provider

No plan for that yet.

Will it be acceptable if I issue a PR?

What kind of PR do you mean?

@cognition9144
Copy link

I think it will be disabling analytics modules in F-droid building pipeline.

@oasisfeng
Copy link
Owner

I think it will be disabling analytics modules in F-droid building pipeline.

Then, I think I have to drop technical support for this build, as the support cost will be significantly increased without statistical analytics for device and ROM.

@oasisfeng
Copy link
Owner

I think it will be disabling analytics modules in F-droid building pipeline.

Then, I think I have to drop technical support for this build, as the support cost will be significantly increased without statistical analytics for device and ROM.

Technically I could use the statistics of device and ROM from normal build to support this build, but that's obviously unfair for users of normal build. So be it.

@cognition9144
Copy link

Roger

@oasisfeng
Copy link
Owner

Roger

Still fork is always welcome.

@cognition9144
Copy link

Roger

Still fork is always welcome.

yeah😀 I'm just trying to see if there's some space I can contribute to the foss world. So maybe I'll help to enhance Shelter instead.

Anyway, much thanks for your contribution to secure Android when we have to install "dirty" apps.

@proletarius101
Copy link

proletarius101 commented Jun 20, 2020

Still fork is always welcome.

I made a fork and it's ready to be submitted to F-droid: https://gitlab.com/secure-system/Insular/-/pipelines

@oasisfeng Is it good if I keep the icon? I'll change it's name in case of confusion, of course.

@oasisfeng
Copy link
Owner

oasisfeng commented Jun 22, 2020

Still fork is always welcome.

I made a fork and it's ready to be submitted to F-droid: https://gitlab.com/secure-system/Insular/-/pipelines

@oasisfeng Is it good if I keep the icon? I'll change it's name in case of confusion, of course.

Conventionally the icon should not be the same or similar, but I can accept an alternative icon with overlay for fork project. Maybe a FOSS mark or so?

Please ensure your fork prject does NOT use the original application ID (com.oasisfeng.island) to avoid confliction in the user side.

@proletarius101
Copy link

proletarius101 commented Jun 22, 2020

Conventionally the icon should not be the same or similar, but I can accept an alternative icon with overlay for fork project. Maybe a FOSS mark or so?

Please ensure your fork prject does NOT use the original application ID (com.oasisfeng.island) to avoid confliction in the user side.

Sure. ID and name are different as per f-droid's policy. A different icon is not compulsory, but it's always better to get your consent. I'll try my best to get a Island-inspired icon. After all, the fork only adds a few patches.

@subiol
Copy link

subiol commented Jul 2, 2020

Any idea when we will be able to install insular from f-droid?

@proletarius101
Copy link

Any idea when we will be able to install insular from f-droid?

Track it here: https://gitlab.com/fdroid/rfp/-/issues/1393

@proletarius101
Copy link

proletarius101 commented Aug 26, 2020

Then, I think I have to drop technical support for this build, as the support cost will be significantly increased without statistical analytics for device and ROM.

@oasisfeng  To make maintainance of the F-droid fork easier, would it be acceptable to include a commit that enabling build flags (like gilbsgilbs/fenix@b3fb44)? Of course, you don't need to provide tech support or anything for the FOSS build and it will bascially be built automatically.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

6 participants