-
Notifications
You must be signed in to change notification settings - Fork 194
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Inclusion in F-Droid #10
Comments
I'm afraid Island may not be qualified for F-Droid, as closed-source libraries (e.g. Firebase) are used. |
Well I wasn't aware of the use of Firebase because it's not written in the gradle file I checked but in the other one. Could you instead provide an apk with each release in the corresponding section here on Github? |
I have plan to do that, but need a bit of work to build the CI environment. Before that, you can download the APKs here: https://www.dropbox.com/sh/3fmjigfejcu0kko/AABJy7du0DQx2Jn_R0uQcy6Ea?dl=0 |
Thanks a lot 👍 Looking forward for the apks in the release section, since it's a lot easier to update ;) |
APK is already included for recent releases. |
You could make a gradle build exclusively for F-Droid, perhaps with an alternative analytics provider |
No plan for that yet. |
Will it be acceptable if I issue a PR? |
What kind of PR do you mean? |
I think it will be disabling analytics modules in F-droid building pipeline. |
Then, I think I have to drop technical support for this build, as the support cost will be significantly increased without statistical analytics for device and ROM. |
Technically I could use the statistics of device and ROM from normal build to support this build, but that's obviously unfair for users of normal build. So be it. |
Roger |
Still fork is always welcome. |
yeah😀 I'm just trying to see if there's some space I can contribute to the foss world. So maybe I'll help to enhance Shelter instead. Anyway, much thanks for your contribution to secure Android when we have to install "dirty" apps. |
I made a fork and it's ready to be submitted to F-droid: https://gitlab.com/secure-system/Insular/-/pipelines @oasisfeng Is it good if I keep the icon? I'll change it's name in case of confusion, of course. |
Conventionally the icon should not be the same or similar, but I can accept an alternative icon with overlay for fork project. Maybe a FOSS mark or so? Please ensure your fork prject does NOT use the original application ID (com.oasisfeng.island) to avoid confliction in the user side. |
Sure. ID and name are different as per f-droid's policy. A different icon is not compulsory, but it's always better to get your consent. I'll try my best to get a Island-inspired icon. After all, the fork only adds a few patches. |
Any idea when we will be able to install insular from f-droid? |
Track it here: https://gitlab.com/fdroid/rfp/-/issues/1393 |
@oasisfeng To make maintainance of the F-droid fork easier, would it be acceptable to include a commit that enabling build flags (like gilbsgilbs/fenix@b3fb44)? Of course, you don't need to provide tech support or anything for the FOSS build and it will bascially be built automatically. |
Hi,
Since this app is Apache v2 licensed, are you considering the fact to add it to F-Droid? There is a strong community behind.
You can find some documentation here.
Otherwise, if you don't want to work on the inclusion of this app by yourself, would it be ok for you if someone else do it for you?
The text was updated successfully, but these errors were encountered: