Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

storage/client should retry requests #1865

Closed
ptrus opened this issue Jun 26, 2019 · 0 comments · Fixed by #2669
Closed

storage/client should retry requests #1865

ptrus opened this issue Jun 26, 2019 · 0 comments · Fixed by #2669
Assignees
Labels
c:storage Category: storage p:1 Priority: core feature

Comments

@ptrus
Copy link
Member

ptrus commented Jun 26, 2019

storage/client should be made to retry requests:

Details:
Currently this can happen if connection to storage node is temporary non available:

{"caller":"balancer.go:130","level":"info","module":"grpc","msg":"base.baseBalancer: handle SubConn state change: 0xc0234a3990, TRANSIENT_FAILURE","ts":"2019-06-26T15:03:03.077707564Z"}
thread '<unnamed>' panicked at 'called `Result::unwrap()` on an `Err` value: ErrorMessage { msg: "rpc error: code = Unavailable desc = transport is closing" }

stack backtrace:
   0: failure::backtrace::internal::InternalBacktrace::new::h88fc859829218a81 (0x55e8566d7b19)
   1: failure::backtrace::Backtrace::new::hdbcb3dafa05cdaac (0x55e8566d7c19)', src/libcore/result.rs:999:5
stack backtrace:
   0: backtrace::backtrace::libunwind::trace
             at ./cargo/registry/src/github.com-1ecc6299db9ec823/backtrace-0.3.25/src/backtrace/libunwind.rs:97
   1: backtrace::backtrace::trace_unsynchronized
             at ./cargo/registry/src/github.com-1ecc6299db9ec823/backtrace-0.3.25/src/backtrace/mod.rs:66
   2: std::sys_common::backtrace::_print
             at src/libstd/sys_common/backtrace.rs:47
   3: std::sys_common::backtrace::print
             at src/libstd/sys_common/backtrace.rs:36
   4: std::panicking::default_hook::{{closure}}
             at src/libstd/panicking.rs:197
   5: std::panicking::default_hook
@ptrus ptrus added the c:storage Category: storage label Jun 26, 2019
@ptrus ptrus changed the title Storage/client should retry requests storage/client should retry requests Jun 26, 2019
@Yawning Yawning added the p:1 Priority: core feature label Jun 26, 2019
@tjanez tjanez self-assigned this Jul 1, 2019
@kostko kostko assigned kostko and unassigned tjanez Feb 12, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
c:storage Category: storage p:1 Priority: core feature
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants