Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enforce limits for storage operations #1914

Closed
3 tasks
kostko opened this issue Jul 12, 2019 · 0 comments · Fixed by #2618
Closed
3 tasks

Enforce limits for storage operations #1914

kostko opened this issue Jul 12, 2019 · 0 comments · Fixed by #2618
Assignees
Labels
c:security Category: security issues c:storage Category: storage epic Epic (costed tracking issue)

Comments

@kostko
Copy link
Member

kostko commented Jul 12, 2019

Currently the client can submit arbitrarily large batches of storage operations which can cause significant load on the storage node. We should review all operations and make sure that they have sensible limits in place.

  • Limit the depth of forked roots to prevent increasing the number of passes that need to be done in Finalize. The depth should currently be limited to 2 as this is the maximum depth that is currently generated during normal operation.
  • Limit the size of storage batches in Apply.
  • Limit the amount of Apply operations in a round based on identity and role of caller (e.g., a txn scheduler node may only commit up to the number of compute committees I/O roots, a compute node may only commit 1 I/O root and 1 state root, a merge node may only merge).

Estimated cost: 1 sprint

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
c:security Category: security issues c:storage Category: storage epic Epic (costed tracking issue)
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant