Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Simplify sentry node setup #2362

Closed
tjanez opened this issue Nov 11, 2019 · 2 comments · Fixed by #2560
Closed

Simplify sentry node setup #2362

tjanez opened this issue Nov 11, 2019 · 2 comments · Fixed by #2560
Assignees
Labels
c:cli Category: command line interface c:consensus/tendermint Category: Tendermint-based consensus

Comments

@tjanez
Copy link
Member

tjanez commented Nov 11, 2019

After initial Sentry node support is implemented, simplify the sentry node setup:

  • Instead of manually and statically specifying sentry nodes as validator's persistent peers, support automatically configuring them upon querying sentry nodes for their consensus addresses and automatically restarting the Tenderming service (if necessary).
  • Instead of manually disabling Tendermint's Peer exchange reactor when using sentry nodes, do that automatically (if sentry nodes are configured).
@kostko kostko added c:cli Category: command line interface c:consensus/tendermint Category: Tendermint-based consensus labels Dec 3, 2019
@ptrus ptrus self-assigned this Dec 3, 2019
@ptrus
Copy link
Member

ptrus commented Jan 17, 2020

Instead of manually and statically specifying sentry nodes as validator's persistent peers, support automatically configuring them upon querying sentry nodes for their consensus addresses and automatically restarting the Tenderming service (if necessary).

looking at the tendermint code, this would require restarting the tedermint service. That together with the fact that validators don't technically need to specify sentries as persistent peers probably makes implementing this not really worth considering the effort vs benefits.

Instead of manually disabling Tendermint's Peer exchange reactor when using sentry nodes, do that automatically (if sentry nodes are configured).

Since disable_pex flag is useful by itself (e.g. someone might want to connect to known trusted nodes via persistent peers and disable pex) i think having to manually disable pex reactor is fine.

However i did try to address some other "simplifications" in #2560

@kostko
Copy link
Member

kostko commented Jan 18, 2020

Since disable_pex flag is useful by itself (e.g. someone might want to connect to known trusted nodes via persistent peers and disable pex) i think having to manually disable pex reactor is fine.

Yeah having an option to disable PEX manually seems reasonable, but is there ever a need for having PEX enabled on the upstream node when using sentry nodes? If not, you can do both -- keep the manual "disable PEX" option and also automatically disable PEX on the upstream node when using sentry nodes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
c:cli Category: command line interface c:consensus/tendermint Category: Tendermint-based consensus
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants