-
Notifications
You must be signed in to change notification settings - Fork 106
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
host/protocol: add RuntimeID to WorkerInfoRequest and use it #2529
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kostko
reviewed
Jan 9, 2020
matevz
force-pushed
the
matevz/feature/stop-hardcoding-runtime-ids
branch
from
January 10, 2020 11:36
fb04505
to
c29d583
Compare
Codecov Report
@@ Coverage Diff @@
## master #2529 +/- ##
==========================================
- Coverage 67.09% 67.07% -0.03%
==========================================
Files 330 330
Lines 30562 30564 +2
==========================================
- Hits 20506 20501 -5
- Misses 7508 7516 +8
+ Partials 2548 2547 -1
Continue to review full report at Codecov.
|
kostko
reviewed
Jan 13, 2020
matevz
force-pushed
the
matevz/feature/stop-hardcoding-runtime-ids
branch
from
January 13, 2020 11:34
1ec2880
to
41b61a4
Compare
kostko
reviewed
Jan 13, 2020
matevz
force-pushed
the
matevz/feature/stop-hardcoding-runtime-ids
branch
from
January 15, 2020 13:26
0d35078
to
06dfdeb
Compare
kostko
approved these changes
Jan 15, 2020
matevz
force-pushed
the
matevz/feature/stop-hardcoding-runtime-ids
branch
from
January 15, 2020 15:28
189ce92
to
32e106f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR for #2519 and #1062:
RuntimeID
field toWorkerInfoRequest
,runtime_id
to runtimeProtocol
runtime_id
equals the CLI passed one,multiple-runtimes
e2e test which spins up 2 runtimes on each compute node with shared runtime binary,make force-test
rule to go/ for running all tests without taking caching into account,oasis-test-runner list
.