Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

host/protocol: add RuntimeID to WorkerInfoRequest and use it #2529

Merged
merged 1 commit into from
Jan 15, 2020

Conversation

matevz
Copy link
Member

@matevz matevz commented Jan 9, 2020

PR for #2519 and #1062:

  • adds RuntimeID field to WorkerInfoRequest,
  • adds runtime_id to runtime Protocol
  • adds check to simple-keyvalue client that remote runtime_id equals the CLI passed one,
  • adds new multiple-runtimes e2e test which spins up 2 runtimes on each compute node with shared runtime binary,
  • adds make force-test rule to go/ for running all tests without taking caching into account,
  • adds sorting scenarios alphabetically when calling oasis-test-runner list.

go/worker/common/host/protocol/types.go Outdated Show resolved Hide resolved
runtime/src/types.rs Outdated Show resolved Hide resolved
go/worker/common/host/sandboxed.go Outdated Show resolved Hide resolved
@codecov
Copy link

codecov bot commented Jan 10, 2020

Codecov Report

Merging #2529 into master will decrease coverage by 0.02%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2529      +/-   ##
==========================================
- Coverage   67.09%   67.07%   -0.03%     
==========================================
  Files         330      330              
  Lines       30562    30564       +2     
==========================================
- Hits        20506    20501       -5     
- Misses       7508     7516       +8     
+ Partials     2548     2547       -1
Impacted Files Coverage Δ
go/registry/api/runtime.go 38.7% <ø> (ø) ⬆️
go/worker/common/host/protocol/types.go 20% <ø> (ø) ⬆️
go/common/version/version.go 84% <ø> (ø) ⬆️
go/worker/common/host/sandboxed.go 75.59% <100%> (+4.28%) ⬆️
go/worker/common/host/interface.go 38.46% <0%> (-15.39%) ⬇️
...consensus/tendermint/apps/roothash/transactions.go 51.13% <0%> (-6.82%) ⬇️
go/worker/storage/service_external.go 47.61% <0%> (-6.35%) ⬇️
go/worker/keymanager/worker.go 59.45% <0%> (-3.61%) ⬇️
go/storage/metrics.go 70.53% <0%> (-2.68%) ⬇️
go/worker/txnscheduler/committee/node.go 63.06% <0%> (-2.1%) ⬇️
... and 15 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 529e2a7...32e106f. Read the comment docs.

runtime/src/protocol.rs Outdated Show resolved Hide resolved
runtime/src/protocol.rs Outdated Show resolved Hide resolved
@matevz matevz force-pushed the matevz/feature/stop-hardcoding-runtime-ids branch from 1ec2880 to 41b61a4 Compare January 13, 2020 11:34
@matevz matevz marked this pull request as ready for review January 13, 2020 11:42
runtime/src/protocol.rs Outdated Show resolved Hide resolved
tests/runtimes/simple-keyvalue/api/src/api.rs Outdated Show resolved Hide resolved
tests/runtimes/simple-keyvalue/src/main.rs Outdated Show resolved Hide resolved
@matevz matevz force-pushed the matevz/feature/stop-hardcoding-runtime-ids branch from 0d35078 to 06dfdeb Compare January 15, 2020 13:26
.changelog/2529.feature.md Outdated Show resolved Hide resolved
@matevz matevz force-pushed the matevz/feature/stop-hardcoding-runtime-ids branch from 189ce92 to 32e106f Compare January 15, 2020 15:28
@matevz matevz merged commit bebc656 into master Jan 15, 2020
@matevz matevz deleted the matevz/feature/stop-hardcoding-runtime-ids branch January 15, 2020 15:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants