Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't allow duplicate P2P connections from the same IP by default #2558

Merged
merged 1 commit into from
Jan 16, 2020

Conversation

peterjgilbert
Copy link
Contributor

No description provided.

@peterjgilbert peterjgilbert force-pushed the peterjgilbert/bugfix/p2p_duplicate_ips branch 2 times, most recently from 6c6a7c1 to fe5f548 Compare January 16, 2020 03:21
@codecov
Copy link

codecov bot commented Jan 16, 2020

Codecov Report

Merging #2558 into master will increase coverage by 0.13%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2558      +/-   ##
==========================================
+ Coverage   67.34%   67.48%   +0.13%     
==========================================
  Files         330      330              
  Lines       30564    30566       +2     
==========================================
+ Hits        20582    20626      +44     
+ Misses       7447     7413      -34     
+ Partials     2535     2527       -8
Impacted Files Coverage Δ
go/consensus/tendermint/tendermint.go 66.18% <100%> (+1.53%) ⬆️
go/worker/keymanager/service.go 55.55% <0%> (-22.23%) ⬇️
go/worker/common/host/interface.go 53.84% <0%> (-15.39%) ⬇️
...consensus/tendermint/apps/roothash/transactions.go 51.13% <0%> (-6.82%) ⬇️
go/worker/keymanager/worker.go 59.45% <0%> (-3.61%) ⬇️
go/runtime/tagindexer/tagindexer.go 68.96% <0%> (-2.3%) ⬇️
go/roothash/api/commitment/pool.go 68.43% <0%> (-2.07%) ⬇️
go/storage/mkvs/urkel/iterator.go 83.76% <0%> (-1.3%) ⬇️
go/runtime/transaction/transaction.go 78.04% <0%> (-1.22%) ⬇️
go/worker/merge/committee/node.go 75.9% <0%> (-0.25%) ⬇️
... and 15 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update bebc656...23611ec. Read the comment docs.

Copy link
Contributor

@Yawning Yawning left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Edit: I'm dumb and sleep deprived.

This won't fix the root cause, and it's still possible to do horrible things to the network.

go/consensus/tendermint/tendermint.go Outdated Show resolved Hide resolved
@peterjgilbert peterjgilbert force-pushed the peterjgilbert/bugfix/p2p_duplicate_ips branch from fe5f548 to daba030 Compare January 16, 2020 04:23
@peterjgilbert peterjgilbert force-pushed the peterjgilbert/bugfix/p2p_duplicate_ips branch from daba030 to 23611ec Compare January 16, 2020 04:36
@peterjgilbert peterjgilbert merged commit 66caa2a into master Jan 16, 2020
@peterjgilbert peterjgilbert deleted the peterjgilbert/bugfix/p2p_duplicate_ips branch January 16, 2020 04:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants