Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

go/extra/stats: handle nil-votes and non-registered nodes #2566

Merged
merged 1 commit into from
Jan 17, 2020

Conversation

ptrus
Copy link
Member

@ptrus ptrus commented Jan 17, 2020

  • tested it on current state of the questnet

@ptrus ptrus force-pushed the ptrus/fix/stats branch 3 times, most recently from ca74e16 to f2f1b2c Compare January 17, 2020 18:24
@codecov
Copy link

codecov bot commented Jan 17, 2020

Codecov Report

Merging #2566 into master will increase coverage by 0.03%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2566      +/-   ##
==========================================
+ Coverage   63.55%   63.58%   +0.03%     
==========================================
  Files         347      347              
  Lines       32397    32397              
==========================================
+ Hits        20589    20600      +11     
+ Misses       9261     9224      -37     
- Partials     2547     2573      +26
Impacted Files Coverage Δ
go/worker/storage/service_internal.go 0% <0%> (-53.34%) ⬇️
go/worker/storage/api/grpc.go 20% <0%> (-22.86%) ⬇️
go/worker/keymanager/service.go 55.55% <0%> (-22.23%) ⬇️
go/worker/storage/service_external.go 47.61% <0%> (-9.53%) ⬇️
...consensus/tendermint/apps/roothash/transactions.go 51.13% <0%> (-6.82%) ⬇️
go/storage/mkvs/urkel/prefetch.go 59.32% <0%> (-3.39%) ⬇️
go/storage/metrics.go 70.53% <0%> (-2.68%) ⬇️
go/consensus/tendermint/roothash/roothash.go 68.91% <0%> (-2.63%) ⬇️
go/roothash/api/commitment/pool.go 68.43% <0%> (-2.07%) ⬇️
go/keymanager/client/client.go 73.86% <0%> (-1.51%) ⬇️
... and 11 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d423c0d...d58df91. Read the comment docs.

@ptrus ptrus merged commit 02d7fc4 into master Jan 17, 2020
@ptrus ptrus deleted the ptrus/fix/stats branch January 17, 2020 20:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants