Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

go/tendermint/keymanager: error Status() if keymanager doesn't exist #2628

Merged
merged 1 commit into from
Jan 31, 2020

Conversation

ptrus
Copy link
Member

@ptrus ptrus commented Jan 31, 2020

This fixes panics in keymanager client if key manager doesn't exist.

@ptrus ptrus force-pushed the ptrus/fix/keymanager-status branch 2 times, most recently from 06d2b27 to 0953dd2 Compare January 31, 2020 11:34
@ptrus ptrus force-pushed the ptrus/fix/keymanager-status branch from 0953dd2 to b7c97ea Compare January 31, 2020 11:37
@ptrus ptrus requested a review from kostko January 31, 2020 11:38
@codecov
Copy link

codecov bot commented Jan 31, 2020

Codecov Report

Merging #2628 into master will decrease coverage by 0.03%.
The diff coverage is 87.5%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2628      +/-   ##
==========================================
- Coverage   63.17%   63.13%   -0.04%     
==========================================
  Files         360      360              
  Lines       34046    34048       +2     
==========================================
- Hits        21507    21497      -10     
- Misses       9879     9895      +16     
+ Partials     2660     2656       -4
Impacted Files Coverage Δ
go/keymanager/api/api.go 66.66% <ø> (ø) ⬆️
...onsensus/tendermint/apps/keymanager/state/state.go 86.04% <100%> (ø) ⬆️
...consensus/tendermint/apps/keymanager/keymanager.go 61.74% <85.71%> (+0.52%) ⬆️
go/consensus/api/grpc.go 57.02% <0%> (-6.62%) ⬇️
go/runtime/history/prune.go 74.19% <0%> (-3.23%) ⬇️
go/storage/metrics.go 73.21% <0%> (-2.68%) ⬇️
go/storage/mkvs/urkel/lookup.go 72.72% <0%> (-2.28%) ⬇️
go/consensus/tendermint/tendermint.go 65.55% <0%> (-1.4%) ⬇️
go/runtime/transaction/transaction.go 77.1% <0%> (-1.21%) ⬇️
go/worker/compute/executor/committee/node.go 61.66% <0%> (-1.19%) ⬇️
... and 6 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b3ee039...b7c97ea. Read the comment docs.

@ptrus ptrus merged commit c33af55 into master Jan 31, 2020
@ptrus ptrus deleted the ptrus/fix/keymanager-status branch January 31, 2020 12:19
Copy link
Member

@kostko kostko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants