Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

go/consensus/tendermint: Expose more P2P config params #2646

Merged
merged 1 commit into from
Feb 6, 2020

Conversation

peterjgilbert
Copy link
Contributor

@peterjgilbert peterjgilbert commented Feb 5, 2020

@codecov
Copy link

codecov bot commented Feb 5, 2020

Codecov Report

Merging #2646 into master will decrease coverage by 0.02%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2646      +/-   ##
==========================================
- Coverage   62.99%   62.97%   -0.03%     
==========================================
  Files         365      364       -1     
  Lines       34378    34338      -40     
==========================================
- Hits        21658    21624      -34     
+ Misses      10047    10040       -7     
- Partials     2673     2674       +1
Impacted Files Coverage Δ
go/consensus/tendermint/tendermint.go 66.2% <100%> (-0.74%) ⬇️
go/runtime/committee/committee.go 74.02% <0%> (-10.39%) ⬇️
go/consensus/api/grpc.go 57.02% <0%> (-6.62%) ⬇️
go/worker/storage/service_external.go 47.19% <0%> (-4.5%) ⬇️
go/oasis-node/cmd/identity/identity.go 47.36% <0%> (-2.64%) ⬇️
go/runtime/committee/nodes.go 80.64% <0%> (-2.16%) ⬇️
go/runtime/transaction/transaction.go 77.1% <0%> (-1.21%) ⬇️
go/worker/compute/executor/committee/node.go 61.66% <0%> (-1.19%) ⬇️
go/oasis-node/cmd/debug/tendermint/tendermint.go 11.36% <0%> (-1.14%) ⬇️
... and 9 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 942511e...46821eb. Read the comment docs.

go/consensus/tendermint/tendermint.go Outdated Show resolved Hide resolved
@peterjgilbert peterjgilbert force-pushed the peterjgilbert/feature/p2p-config branch from c6238e3 to 3199b16 Compare February 6, 2020 15:35
@peterjgilbert peterjgilbert added the c:breaking/cfg Category: breaks configuration label Feb 6, 2020
@peterjgilbert peterjgilbert force-pushed the peterjgilbert/feature/p2p-config branch 2 times, most recently from eec0274 to 14bb7db Compare February 6, 2020 16:57
@peterjgilbert peterjgilbert force-pushed the peterjgilbert/feature/p2p-config branch from 14bb7db to 46821eb Compare February 6, 2020 17:12
@peterjgilbert peterjgilbert merged commit edf1978 into master Feb 6, 2020
@peterjgilbert peterjgilbert deleted the peterjgilbert/feature/p2p-config branch February 6, 2020 17:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
c:breaking/cfg Category: breaks configuration
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Expose more consensus P2P configuration parameters
2 participants