Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

go/staking/api: Fix genesis sanity check for nonexisting accounts #2671

Merged
merged 1 commit into from
Feb 13, 2020

Conversation

tjanez
Copy link
Member

@tjanez tjanez commented Feb 13, 2020

Detect when a (debonding) delegation is specified for a nonexisting account and report an appropriate error.

Detect when a (debonding) delegation is specified for a nonexisting
account and report an appropriate error.
@tjanez tjanez force-pushed the tjanez/fix-staking-sanity-check branch from b46c4d8 to 3d437c7 Compare February 13, 2020 17:16
@codecov
Copy link

codecov bot commented Feb 13, 2020

Codecov Report

Merging #2671 into master will decrease coverage by 0.02%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2671      +/-   ##
==========================================
- Coverage   63.07%   63.04%   -0.03%     
==========================================
  Files         365      365              
  Lines       34586    34592       +6     
==========================================
- Hits        21815    21810       -5     
- Misses      10060    10063       +3     
- Partials     2711     2719       +8     
Impacted Files Coverage Δ
go/worker/storage/service_external.go 47.19% <0.00%> (-4.50%) ⬇️
go/runtime/tagindexer/tagindexer.go 68.47% <0.00%> (-4.35%) ⬇️
go/runtime/transaction/transaction.go 74.69% <0.00%> (-3.62%) ⬇️
go/oasis-node/cmd/debug/storage/storage.go 45.08% <0.00%> (-3.47%) ⬇️
go/worker/keymanager/worker.go 60.00% <0.00%> (-2.99%) ⬇️
go/worker/common/p2p/p2p.go 64.86% <0.00%> (-2.71%) ⬇️
go/storage/mkvs/urkel/iterator.go 82.46% <0.00%> (-2.60%) ⬇️
go/storage/client/client.go 74.78% <0.00%> (-1.74%) ⬇️
go/storage/mkvs/urkel/cache.go 81.27% <0.00%> (-1.71%) ⬇️
go/worker/compute/executor/committee/node.go 61.66% <0.00%> (-1.19%) ⬇️
... and 11 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update aad6d64...3d437c7. Read the comment docs.

@tjanez tjanez merged commit f79998e into master Feb 13, 2020
@tjanez tjanez deleted the tjanez/fix-staking-sanity-check branch February 13, 2020 17:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants