Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

go staking: add per-account lockup #2672

Merged
merged 2 commits into from
Feb 14, 2020
Merged

go staking: add per-account lockup #2672

merged 2 commits into from
Feb 14, 2020

Conversation

pro-wh
Copy link
Contributor

@pro-wh pro-wh commented Feb 13, 2020

With this, we'll be able to set up special accounts in the genesis document where they're not permitted to transfer staking tokens until a the specified epoch time. They can still delegate during that time.

@pro-wh pro-wh added c:consensus/tendermint Category: Tendermint-based consensus c:staking Category: staking labels Feb 13, 2020
@ryscheng
Copy link
Contributor

ryscheng commented Feb 14, 2020

Codecov Report

Merging #2672 into master will increase coverage by 0.14%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2672      +/-   ##
==========================================
+ Coverage   63.05%   63.20%   +0.14%     
==========================================
  Files         376      376              
  Lines       35314    35319       +5     
==========================================
+ Hits        22267    22322      +55     
+ Misses      10244    10212      -32     
+ Partials     2803     2785      -18     
Impacted Files Coverage Δ
go/consensus/tendermint/api/api.go 73.58% <0.00%> (-15.10%) ⬇️
go/storage/mkvs/urkel/lookup.go 72.72% <0.00%> (-2.28%) ⬇️
go/runtime/committee/nodes.go 80.64% <0.00%> (-2.16%) ⬇️
...o/consensus/tendermint/apps/scheduler/scheduler.go 71.70% <0.00%> (-1.38%) ⬇️
go/worker/registration/worker.go 66.66% <0.00%> (-0.50%) ⬇️
go/consensus/api/grpc.go 57.02% <0.00%> (ø) ⬆️
go/storage/api/grpc.go 70.56% <0.00%> (+0.66%) ⬆️
go/worker/common/p2p/p2p.go 68.46% <0.00%> (+0.90%) ⬆️
go/consensus/tendermint/tendermint.go 66.20% <0.00%> (+0.96%) ⬆️
go/common/grpc/grpc.go 78.83% <0.00%> (+1.24%) ⬆️
... and 12 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ab41005...b50c11d. Read the comment docs.

@pro-wh
Copy link
Contributor Author

pro-wh commented Feb 14, 2020

thanks @ryscheng

@pro-wh pro-wh merged commit 314bce8 into master Feb 14, 2020
@pro-wh pro-wh deleted the pro-wh/feature/notbefore branch February 14, 2020 19:24
pro-wh added a commit that referenced this pull request Mar 4, 2020
…ore"

This reverts commit 314bce8, reversing
changes made to ab41005.
pro-wh added a commit that referenced this pull request Mar 5, 2020
…ore"

This reverts commit 314bce8, reversing
changes made to ab41005.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
c:consensus/tendermint Category: Tendermint-based consensus c:staking Category: staking
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants