runtime: Remove the non-webpki/snow related uses of ring #2733
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Yawning
changed the title
Yawning
force-pushed
the
yawning/fix/de-ringify
branch
from
64d7272
to
76fffc6
Compare
Yawning
requested review from
kostko,
peterjgilbert and
pro-wh
as code owners
kostko
approved these changes
Feb 27, 2020
As much as I like the concept of ring as a library, and the implementation, the SGX support situation is rediculous, and we should minimize the use of the library for cases where alternatives exist.
Yawning
force-pushed
the
yawning/fix/de-ringify
branch
from
76fffc6
to
73aacaa
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As much as I like the concept of ring as a library, and the
implementation, the SGX support situation is rediculous, and we should
minimize the use of the library for cases where alternatives exist.
Part of #2683.