Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add withdrawal/deposit/transfer check if destination is ParaTime or other non-withdrawable address #7

Closed
matevz opened this issue Oct 20, 2022 · 0 comments · Fixed by #1
Labels
ui Improve user experience

Comments

@matevz
Copy link
Member

matevz commented Oct 20, 2022

One could do the following stupidity, which is not very obvious

oasis accounts deposit 10 paratime:emerald

because to is an optional argument to deposit cmd and paratime:emerald is a built-in address, instead of

oasis accounts deposit 10 --paratime emerald

This would lock the tokens forever. Same goes for transfers or withdrawals, although less likely. Add a check similar to CheckLocalAccountIsConsensusCapable() which would prevent you from moving tokens to reserved addresses for ParaTimes, common staking pool, the new burn pool etc.

@tjanez tjanez transferred this issue from oasisprotocol/oasis-sdk Jan 4, 2023
@tjanez tjanez added the ui Improve user experience label Jan 4, 2023
@matevz matevz closed this as completed in #1 Jan 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ui Improve user experience
Projects
None yet
2 participants