Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

indexer: replace failed tx #207

Merged
merged 2 commits into from
Mar 9, 2022
Merged

indexer: replace failed tx #207

merged 2 commits into from
Mar 9, 2022

Conversation

pro-wh
Copy link
Contributor

@pro-wh pro-wh commented Mar 9, 2022

handle cases where an earlier sighting of a tx failed and a later sighting succeeded

@pro-wh pro-wh requested review from kostko and ptrus as code owners March 9, 2022 03:15
@pro-wh pro-wh force-pushed the pro-wh/bugfix/txreplace-main branch 3 times, most recently from ce2dd9f to 9225090 Compare March 9, 2022 03:44
@codecov
Copy link

codecov bot commented Mar 9, 2022

Codecov Report

Merging #207 (0b9b644) into main (b542c5e) will decrease coverage by 0.42%.
The diff coverage is 13.33%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #207      +/-   ##
==========================================
- Coverage   60.49%   60.06%   -0.43%     
==========================================
  Files          24       24              
  Lines        2721     2747      +26     
==========================================
+ Hits         1646     1650       +4     
- Misses        897      917      +20     
- Partials      178      180       +2     
Impacted Files Coverage Δ
indexer/utils.go 71.55% <13.33%> (-4.86%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b542c5e...0b9b644. Read the comment docs.

@pro-wh pro-wh force-pushed the pro-wh/bugfix/txreplace-main branch from 9225090 to 0b9b644 Compare March 9, 2022 04:02
@peterjgilbert peterjgilbert self-requested a review March 9, 2022 05:00
@ptrus ptrus force-pushed the pro-wh/bugfix/txreplace-main branch from 0b9b644 to 50693b1 Compare March 9, 2022 12:30
@ptrus ptrus merged commit 2eabfef into main Mar 9, 2022
@ptrus ptrus deleted the pro-wh/bugfix/txreplace-main branch March 9, 2022 12:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants