feat(indexer): Improve cache memory efficiency #260
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Yawning
force-pushed
the
yawning/feature/252
branch
from
64e5a79
to
df8fbac
Compare
Codecov Report
@@ Coverage Diff @@
## main #260 +/- ##
==========================================
- Coverage 63.04% 62.18% -0.86%
==========================================
Files 34 34
Lines 3810 3819 +9
==========================================
- Hits 2402 2375 -27
- Misses 1207 1246 +39
+ Partials 201 198 -3
Continue to review full report at Codecov.
|
Yawning
force-pushed
the
yawning/feature/252
branch
5 times, most recently
from
431fd93
to
d59f37c
Compare
|
While I am marking this ready for review, I'm not sure how much of a performance difference this will make. |
ptrus
approved these changes
Apr 11, 2022
Yawning
force-pushed
the
yawning/feature/252
branch
from
d59f37c
to
930f82f
Compare
Instead of using a complicated cache implementation, just use a handful of sync.Maps along with a "remove eldest" replacement policy.
Yawning
force-pushed
the
yawning/feature/252
branch
from
dfccdc6
to
342ea05
Compare
ptrus
approved these changes
Apr 13, 2022
| Receipts []*model.Receipt | ||
| Block *model.Block | ||
| Receipts []*model.Receipt | ||
| UniqueTxes []*model.Transaction |
There was a problem hiding this comment.
Oh, yeah this is correct, I shouldn't have changed this
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Instead of using a complicated cache implementation, just use a handful
of sync.Maps along with a "remove eldest" replacement policy. Since our
critical-path access patterns are overwhelmingly for temporally recent data
the new policy also makes it impossible for the hot dataset to be evicted.
Implements #252