Display the votes on the network proposal details page (simplified version) #1356
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Deployed to Cloudflare Pages
|
csillag
force-pushed
the
csillag/proposal-show-votes-simplified
branch
3 times, most recently
from
c445593
to
2d971f4
Compare
This was referenced Mar 31, 2024
csillag
force-pushed
the
csillag/proposal-show-votes-simplified
branch
from
2d971f4
to
c6913a8
Compare
lukaw3d
reviewed
Apr 2, 2024
| export const ProposalVoteIndicator: FC<ProposalVoteIndicatorProps> = ({ vote }) => { | ||
| const { t } = useTranslation() | ||
|
|
||
| if (!ProposalVoteValue[vote]) { |
There was a problem hiding this comment.
When does this happen? I would throw an error - response doesn't match types
There was a problem hiding this comment.
OK, throwing an error now. The question is, on which level do we want to catch it (with a boundary)?
My guess is that we stall want to see as much of the list as possible, so let's catch it within the table cell, like this:
Is that how you would do it? Or should the error kill the whole list?
There was a problem hiding this comment.
From a user's perspective, we should show as much as possible. Showing a full invalid view does not help the user.
csillag
force-pushed
the
csillag/proposal-show-votes-simplified
branch
9 times, most recently
from
7da7549
to
2aea726
Compare
csillag
force-pushed
the
csillag/proposal-show-votes-simplified
branch
4 times, most recently
from
a8531a9
to
b4b912f
Compare
lukaw3d
approved these changes
May 14, 2024
csillag
force-pushed
the
csillag/proposal-show-votes-simplified
branch
from
b4b912f
to
b641559
Compare
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Display votes on the proposal details page.
Design is here.
Some of the required data is not yet provided by nexus, including:
Therefore, some parts are not implemented yet.