Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update routes to conform to EIP-3091 #534

Merged
merged 1 commit into from Jun 14, 2023
Merged

Conversation

csillag
Copy link
Contributor

@csillag csillag commented Jun 14, 2023

See #530 for context.

Tokens are not handled, since we don't have that functionality yet.

@github-actions
Copy link

github-actions bot commented Jun 14, 2023

Deployed to Cloudflare Pages

Latest commit: 856ad162a8c42ff1776c9fc4734813a508bfbac6
Status:✅ Deploy successful!
Preview URL: https://753e72da.oasis-explorer.pages.dev

@csillag csillag force-pushed the csillag/confirm-to-eip3091 branch from d6c9d89 to ef75d82 Compare June 14, 2023 10:09
@matevz
Copy link
Member

matevz commented Jun 14, 2023

See #530 for context.

Tokens are not handled yet.

I can confirm account and tx lookup with Metamask now works. Good job!

@csillag csillag force-pushed the csillag/confirm-to-eip3091 branch from 15788c7 to 5234355 Compare June 14, 2023 10:34
@csillag csillag marked this pull request as ready for review June 14, 2023 10:35
@csillag csillag requested a review from buberdds June 14, 2023 10:35
.changelog/524.cfg.md Outdated Show resolved Hide resolved
@csillag csillag force-pushed the csillag/confirm-to-eip3091 branch 2 times, most recently from b368978 to a1bef99 Compare June 14, 2023 10:52
@csillag csillag force-pushed the csillag/confirm-to-eip3091 branch from e779711 to 856ad16 Compare June 14, 2023 11:14
Copy link
Member

@matevz matevz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested with Metamask and manual block/token investigation works fine.

@csillag csillag merged commit 5b31d6a into master Jun 14, 2023
7 checks passed
@csillag csillag deleted the csillag/confirm-to-eip3091 branch June 14, 2023 11:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants