Handle situations when a Paratime is unavailable #619
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Deployed to Cloudflare Pages
|
csillag
force-pushed
the
csillag/handle-unavailable-paratime
branch
from
c17af98
to
9236b7f
Compare
csillag
force-pushed
the
csillag/handle-unavailable-paratime
branch
from
9236b7f
to
a78c56a
Compare
lukaw3d
reviewed
Jun 28, 2023
| const target = getNameForScope(t, scope) | ||
| return ( | ||
| <StickyAlert severity="warning"> | ||
| {lastUpdate | ||
| {unavailable | ||
| ? t('home.runtimeUnavailable', { target }) |
There was a problem hiding this comment.
I would reuse home.apiOffline
but also, this should not be possible on backend. Can we get backend not to do this, instead?
There was a problem hiding this comment.
I would reuse
home.apiOffline
I considered that, but the scope of that warning is too wide to correctly describe this situation. (After all, we can get info about other runtimes...)
but also, this should not be possible on backend. Can we get backend not to do this, instead?
You are certainly welcome to try to pursue them! I have already brought up the topic on the relevant slack channel, and got the answer that this is more or less considered to be normal... in any case, I think it doesn't hurt to have multiple lines of defense here.
lukaw3d
approved these changes
Jun 28, 2023
csillag
force-pushed
the
csillag/handle-unavailable-paratime
branch
from
a78c56a
to
6a3ccdc
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before it was a silent failure