Graph feedback #716
Graph feedback #716
Conversation
lubej
commented
Jul 11, 2023
lubej
commented
- (Desktop) ParaTime should directly navigate when zoomed out.
- When zoomed in the user should be able to see that status of the ParaTime.
- When zoomed into a specific ParaTime any unrelated ParaTimes should have 50% opacity.
- The outer stroke should be display on top of the graph content.
- Reduce opacity on mobile tooltip.
- Fix ‘Coming soon’ label displayed on mobile.
- Shadows cut off on testnet graph.
- Add selected network label.
Deployed to Cloudflare Pages
|
lubej
force-pushed
the
ml/graph-feedback
branch
4 times, most recently
from
2e130b9
to
13505f5
Compare
| [isLayerDisabled], | ||
| ) | ||
|
|
||
| const enabledLayers: Layer[] = useMemo( |
There was a problem hiding this comment.
Enabled layers are defined in RouteUtils.getEnabledLayersForNetwork(network) why we need to find out what layers are enabled based on disabledMap which was created from getEnabledLayersForNetwork?
There was a problem hiding this comment.
It is used on multiple places in the graph, and it just an abstraction, to not repeat the function call.
There was a problem hiding this comment.
but why we need Object.keys(disabledMap).filter(layer => !disabledMap[layer as Layer]).map(layer => layer as Layer), to get enabledLayers when RouteUtils.getEnabledLayersForNetwork(network) returns it?
There was a problem hiding this comment.
Good point. Will simplify.
|
| [Layer.cipher]: isLayerDisabled(Layer.cipher), | ||
| [Layer.sapphire]: isLayerDisabled(Layer.sapphire), | ||
| } | ||
| const isLayerDisabled = useCallback( |
There was a problem hiding this comment.
Why we need to wrap getEnabledLayersForNetwork with useCallback when disabledMap is going to be memoized?
There was a problem hiding this comment.
Due to network dependency. Status call depends on disabledMap, which I want to trigger only when network changes.
