Improve token transfer listing for tokens #738
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Deployed to Cloudflare Pages
|
csillag
force-pushed
the
csillag/improve-token-transfer-listings
branch
from
4ff0aad
to
284c539
Compare
csillag
force-pushed
the
csillag/improve-token-transfer-listings
branch
from
7cfedae
to
7507ce1
Compare
lukaw3d
reviewed
Jul 15, 2023
OK, see #743 |
csillag
force-pushed
the
csillag/improve-token-transfer-listings
branch
from
ad7c964
to
3e7f427
Compare
Done. |
Abstract away more things and centralize them in the pagination engine, so that the pagination engine is in a position where it could do some more sophisticated stuff, like decoupling client-side and server-side behavior.
... of ComprehensiveSearchParamsPagination No actual behavior is changed yet, just copied and renamed.
csillag
force-pushed
the
csillag/improve-token-transfer-listings
branch
2 times, most recently
from
293902e
to
262a7e2
Compare
lukaw3d
approved these changes
Jul 16, 2023
| switch (candidates.length) { | ||
| case 0: | ||
| throw new Error('Data not found!') | ||
| case 1: |
There was a problem hiding this comment.
With strict types this could be ensured at compile time, but not worth inventing it for this temporary workaround until backend adds filtering by signature
This first implementation only loads the first batch from the server, and the works with that data.
csillag
force-pushed
the
csillag/improve-token-transfer-listings
branch
from
262a7e2
to
7de4f79
Compare
Yes, there is |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This depends on #743.Improve pagination experience by proving rudimentary client-side pagination (limitation: looking only at the first 1000 records)
This impacts two pages:
/mainnet/sapphire/token/0x998633BDF6eE32A9CcA6c9A247F428596e8e65d8)/mainnet/sapphire/address/0x998633BDF6eE32A9CcA6c9A247F428596e8e65d8/token-transfers#transfersI think there is some problem with the pagination widget sometimes displaying the wrong number of total pages, but that is totally unrelated.Update: workaround added for anomalous behavior.Technical note: great emphasis has been placed in developing this in separate commits so that it's easier to follow what is going on, so I suggest reviewing commit by commit.