Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Show raw data for unencrypted transactions #896

Merged
merged 1 commit into from Sep 27, 2023

Conversation

csillag
Copy link
Contributor

@csillag csillag commented Sep 26, 2023

From slack:

We currently parse the encrypted result data/nonce from encrypted evm.Call txs(example).
Do we want to do the same for unencrypted results (example)?
The result data/nonce don’t seem that useful for most users, but perhaps we should do it just to be consistent for all encrypted evm.Call txs

Also:

could we add data field to the non-encrypted transaction page as well. example ? I want to show how devs can check whether a transaction is encrypted or not and what's its content

Also:

perhaps we should toggle between Hex and Base64 data (both for encrypted or plain eth transaction) with the Oasis<->ETH switch in the top-right corner?


As a first step, we are now showing:

  • The raw (hex-coded) data for unencrypted transactions

It turns out that the result data/nonce currently isn’t parsed for unencrypted results, which is tracked here

@github-actions
Copy link

github-actions bot commented Sep 26, 2023

Deployed to Cloudflare Pages

Latest commit: e1389da532a5ef275113e9c16e74f7db26d4d243
Status:✅ Deploy successful!
Preview URL: https://1c4d4d7b.oasis-explorer.pages.dev

@csillag csillag force-pushed the csillag/show-raw-unencrypted-data branch from 42de135 to 53eadfd Compare September 26, 2023 16:20
@csillag csillag force-pushed the csillag/show-raw-unencrypted-data branch from 53eadfd to b265a66 Compare September 26, 2023 22:37
@csillag csillag marked this pull request as ready for review September 27, 2023 22:34
@csillag csillag force-pushed the csillag/show-raw-unencrypted-data branch from b265a66 to e1389da Compare September 27, 2023 22:35
@csillag csillag merged commit 7a4705d into master Sep 27, 2023
7 checks passed
@csillag csillag deleted the csillag/show-raw-unencrypted-data branch September 27, 2023 22:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants