Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

code duplication from ledger-oasis repo #288

Open
pro-wh opened this issue Nov 2, 2021 · 0 comments
Open

code duplication from ledger-oasis repo #288

pro-wh opened this issue Nov 2, 2021 · 0 comments

Comments

@pro-wh
Copy link
Contributor

pro-wh commented Nov 2, 2021

Looking at source code in files in src/ in this repo and source code in files in js/src/ in Ledger Oasis app repo, there is a lot of copying/duplication.
What would be the best way to avoid that?

I didn't know about there being a copy of this module in the repo of the app itself. Is this intended? How did the two copies com to be?

I also don't know the genesis of this 🙂.

Can you open an issue in this repo to track this unusual code duplication and we can tackle that separately from this PR?

Originally posted by @tjanez in #270 (comment)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@pro-wh