Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test determinism for evm tokens analyzer #345

Open
pro-wh opened this issue Mar 6, 2023 · 1 comment
Open

test determinism for evm tokens analyzer #345

pro-wh opened this issue Mar 6, 2023 · 1 comment

Comments

@pro-wh
Copy link
Collaborator

pro-wh commented Mar 6, 2023

It's particularly nice for debugging, run comparisons, test writing etc, if the sql statements are ordered deterministically.
Maybe you can sort staleTokens before this for loop? Or probably even better, make getStaleTokens() return ordered results by adding an ORDER BY token_address to the underlying db query.

Originally posted by @mitjat in #344 (comment)

@pro-wh
Copy link
Collaborator Author

pro-wh commented Mar 6, 2023

currently the "stale" tokens are maintained in an index so they're probably ordered by runtime, token_address. might as well make this explicit. if this later causes tokens at higher addresses to starve, we'll have to come up with something else.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant