New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[EXT-SEC-AUDIT] Excessive size limit of Ekiden runtime messages can result in fatal out-of-memory errors #2213

Closed

kostko opened this issue Oct 2, 2019 · 0 comments · Fixed by #3139

Assignees

Labels

c:runtime/compute c:runtime c:security

Member

kostko commented Oct 2, 2019 •

edited

Issue transferred from an external security audit report.

CBOR unmarshalling routines in both Go and Rust set an excessive message size limit of 100 MB. This makes it feasible for an attacker to craft a message which, once accepted and unmarshalled by either routine, consumes a large amount of memory and crashes a node.
https://github.com/oasislabs/oasis-core/blob/7a5ddc8fae312b6d8400fa9ba062604c1112c6a4/go/common/cbor/codec.go#L9-L10

kostko added c:runtime/compute c:runtime c:security labels

Yawning mentioned this issue

go/common/cbor: Add oasis_codec_size metrics #2263

Merged

kostko mentioned this issue

runtime: Reduce maximum RHP message size #3139

Merged

kostko self-assigned this

kostko closed this as completed in #3139

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment