Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

enum checks #2546

Merged
merged 1 commit into from
Jan 22, 2020
Merged

enum checks #2546

merged 1 commit into from
Jan 22, 2020

Conversation

matevz
Copy link
Member

@matevz matevz commented Jan 13, 2020

PR for #2527:

  • adds KindInvalid to RuntimeKind enum,
  • adds KindInvalid to CommitteeKind enum,
  • adds ContextInvalid to ContextType enum,
  • adds HeaderInvalid to HeaderType enum,
  • adds Invalid to artifactType enum both in go and rust,
  • in CommitteeKind enum renames KindExecutor -> KindComputeExecutor, KindTransactionScheduler -> KindComputeTxnScheduler, and KindMerge -> KindComputeMerge.

@matevz matevz force-pushed the matevz/bug/enum-checks branch 2 times, most recently from 1de2c64 to 0291f2a Compare January 16, 2020 16:32
@codecov
Copy link

codecov bot commented Jan 16, 2020

Codecov Report

Merging #2546 into master will increase coverage by 3.47%.
The diff coverage is 30%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2546      +/-   ##
==========================================
+ Coverage   63.55%   67.02%   +3.47%     
==========================================
  Files         347      330      -17     
  Lines       32397    30573    -1824     
==========================================
- Hits        20589    20491      -98     
+ Misses       9261     7534    -1727     
- Partials     2547     2548       +1
Impacted Files Coverage Δ
go/scheduler/api/api.go 88% <ø> (ø) ⬆️
go/registry/api/runtime.go 36.36% <0%> (-2.35%) ⬇️
go/oasis-node/cmd/registry/runtime/runtime.go 57.6% <0%> (-0.43%) ⬇️
go/registry/tests/tester.go 88.21% <100%> (+0.07%) ⬆️
go/consensus/tendermint/apps/registry/genesis.go 53.04% <100%> (ø) ⬆️
go/worker/storage/service_internal.go 0% <0%> (-53.34%) ⬇️
go/worker/storage/api/grpc.go 20% <0%> (-22.86%) ⬇️
go/worker/keymanager/service.go 55.55% <0%> (-22.23%) ⬇️
go/worker/storage/service_external.go 47.61% <0%> (-9.53%) ⬇️
go/consensus/tendermint/keymanager/keymanager.go 79.22% <0%> (-6.5%) ⬇️
... and 78 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d423c0d...72a3591. Read the comment docs.

@codecov-io
Copy link

codecov-io commented Jan 17, 2020

Codecov Report

Merging #2546 into master will increase coverage by 0.36%.
The diff coverage is 77.55%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2546      +/-   ##
==========================================
+ Coverage   63.28%   63.65%   +0.36%     
==========================================
  Files         346      346              
  Lines       32545    32585      +40     
==========================================
+ Hits        20597    20741     +144     
+ Misses       9391     9266     -125     
- Partials     2557     2578      +21
Impacted Files Coverage Δ
go/consensus/tendermint/abci/context.go 79.85% <ø> (ø) ⬆️
go/common/version/version.go 84% <ø> (ø) ⬆️
go/roothash/api/block/header.go 72.97% <ø> (ø) ⬆️
go/registry/api/runtime.go 37.5% <0%> (-1.21%) ⬇️
go/oasis-node/cmd/registry/runtime/runtime.go 57.6% <0%> (-0.43%) ⬇️
go/runtime/transaction/transaction.go 77.1% <0%> (+0.27%) ⬆️
go/consensus/tendermint/apps/registry/genesis.go 53.04% <100%> (ø) ⬆️
go/registry/tests/tester.go 88.05% <100%> (+0.01%) ⬆️
go/runtime/client/watcher.go 75.86% <100%> (ø) ⬆️
go/consensus/tendermint/apps/roothash/roothash.go 72.56% <100%> (ø) ⬆️
... and 26 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e2837d9...7e30dd3. Read the comment docs.

go/runtime/transaction/transaction.go Outdated Show resolved Hide resolved
go/scheduler/api/api.go Outdated Show resolved Hide resolved
go/scheduler/api/api.go Outdated Show resolved Hide resolved
@matevz matevz force-pushed the matevz/bug/enum-checks branch 2 times, most recently from 0beb9a5 to 7419a88 Compare January 20, 2020 11:47
@matevz matevz self-assigned this Jan 20, 2020
go/oasis-node/cmd/registry/runtime/runtime.go Outdated Show resolved Hide resolved
go/registry/api/runtime.go Outdated Show resolved Hide resolved
go/roothash/api/commitment/pool_test.go Outdated Show resolved Hide resolved
go/runtime/transaction/transaction.go Outdated Show resolved Hide resolved
go/runtime/transaction/transaction.go Outdated Show resolved Hide resolved
go/scheduler/api/api.go Outdated Show resolved Hide resolved
go/scheduler/api/api.go Outdated Show resolved Hide resolved
runtime/src/transaction/tree.rs Outdated Show resolved Hide resolved
runtime/src/transaction/tree.rs Outdated Show resolved Hide resolved
@matevz matevz merged commit 04990a3 into master Jan 22, 2020
@matevz matevz deleted the matevz/bug/enum-checks branch January 22, 2020 10:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants