Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

go/oasis-node: Include account ID in stake list -v cmd #2567

Merged
merged 1 commit into from
Jan 17, 2020

Conversation

peterjgilbert
Copy link
Contributor

Fixes #2557

Copy link
Member

@kostko kostko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, add a bugfix changelog fragment.

@codecov
Copy link

codecov bot commented Jan 17, 2020

Codecov Report

Merging #2567 into master will decrease coverage by 0.01%.
The diff coverage is 37.5%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2567      +/-   ##
==========================================
- Coverage   63.58%   63.57%   -0.02%     
==========================================
  Files         347      347              
  Lines       32397    32399       +2     
==========================================
- Hits        20600    20597       -3     
- Misses       9224     9238      +14     
+ Partials     2573     2564       -9
Impacted Files Coverage Δ
go/oasis-node/cmd/stake/stake.go 47.57% <37.5%> (-1.94%) ⬇️
go/consensus/api/grpc.go 57.02% <0%> (-6.62%) ⬇️
go/runtime/client/client.go 69.35% <0%> (-1.62%) ⬇️
go/consensus/tendermint/tendermint.go 65.18% <0%> (-1.44%) ⬇️
go/worker/storage/committee/node.go 79.56% <0%> (-1.37%) ⬇️
go/worker/merge/committee/node.go 76.25% <0%> (+0.23%) ⬆️
go/common/grpc/grpc.go 78.48% <0%> (+0.42%) ⬆️
go/worker/common/p2p/p2p.go 68.46% <0%> (+0.9%) ⬆️
go/worker/executor/committee/node.go 62.77% <0%> (+1.18%) ⬆️
go/runtime/transaction/transaction.go 78.04% <0%> (+1.21%) ⬆️
... and 4 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 02d7fc4...4cd8d09. Read the comment docs.

@peterjgilbert peterjgilbert merged commit 568d426 into master Jan 17, 2020
@peterjgilbert peterjgilbert deleted the peterjgilbert/bugfix/stake_list branch January 17, 2020 20:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

regression on stake list -v, it did not give the id anymore
2 participants