Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

registry: Node descriptors should be signed by all public keys in the node #2599

Closed
Yawning opened this issue Jan 27, 2020 · 0 comments · Fixed by #2600
Closed

registry: Node descriptors should be signed by all public keys in the node #2599

Yawning opened this issue Jan 27, 2020 · 0 comments · Fixed by #2600
Assignees
Labels
c:breaking/consensus Category: breaking consensus changes c:bug Category: bug c:registry Category: entity/node/runtime registry service c:security Category: security issues p:0 Priority: High! bugs, address immediately

Comments

@Yawning
Copy link
Contributor

Yawning commented Jan 27, 2020

The node descriptor isn't actually signed by the consensus, p2p (and in some cases the node descriptor's own) signing keys. This means that there is no proof of possession of the keys, and with duplicated keys being rejected by the consensus layer, it is possible to craft descriptors that cause valid registrations to be rejected.

@Yawning Yawning added p:0 Priority: High! bugs, address immediately c:registry Category: entity/node/runtime registry service c:bug Category: bug c:breaking/consensus Category: breaking consensus changes c:security Category: security issues labels Jan 27, 2020
@Yawning Yawning self-assigned this Jan 27, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
c:breaking/consensus Category: breaking consensus changes c:bug Category: bug c:registry Category: entity/node/runtime registry service c:security Category: security issues p:0 Priority: High! bugs, address immediately
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant