Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cmd/registry/runtime: fix loading entities #2606

Merged
merged 1 commit into from
Jan 28, 2020
Merged

Conversation

ptrus
Copy link
Member

@ptrus ptrus commented Jan 28, 2020

No description provided.

@codecov
Copy link

codecov bot commented Jan 28, 2020

Codecov Report

Merging #2606 into master will decrease coverage by 0.27%.
The diff coverage is 28.57%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2606      +/-   ##
==========================================
- Coverage   63.47%   63.19%   -0.28%     
==========================================
  Files         357      357              
  Lines       33681    33682       +1     
==========================================
- Hits        21379    21287      -92     
- Misses       9698     9772      +74     
- Partials     2604     2623      +19
Impacted Files Coverage Δ
go/oasis-node/cmd/registry/runtime/runtime.go 56.47% <28.57%> (-0.86%) ⬇️
go/storage/mkvs/urkel/writelog/iterator.go 76.36% <0%> (-16.37%) ⬇️
go/worker/common/host/interface.go 38.46% <0%> (-15.39%) ⬇️
go/storage/metrics.go 70.53% <0%> (-8.04%) ⬇️
go/worker/storage/committee/node.go 72.5% <0%> (-7.28%) ⬇️
go/control/debug.go 67.74% <0%> (-6.46%) ⬇️
go/worker/common/p2p/p2p.go 64.86% <0%> (-5.41%) ⬇️
go/storage/api/root_cache.go 70.11% <0%> (-4.6%) ⬇️
go/worker/compute/txnscheduler/committee/node.go 61.9% <0%> (-4.13%) ⬇️
go/storage/database/database.go 77.22% <0%> (-3.97%) ⬇️
... and 14 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6a99a0a...57887f7. Read the comment docs.

@ptrus ptrus self-assigned this Jan 28, 2020
@ptrus ptrus merged commit 82ece0a into master Jan 28, 2020
@ptrus ptrus deleted the ptrus/fix/cmd-registry branch January 28, 2020 13:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants