oasis-node crash during Ethereum runtime's genesis-playback

[matevz]

Steps to reproduce:

1. From oasis-core run oasis-net-runner as stated in the README,
2. Wait a few moments so the nodes get synced,
3. In another terminal from oasis-runtime run genesis-playback state-2999999.json runtimestates.json --commit-every 10000 -a $ADDR --runtime-id 8000000000000000000000000000000000000000000000000000000000000000 where $ADDR is the path to you storage socket.
4. Wait until around transaction 110k, oasis-node crashes.

Attached storage-0/console.log from oasis-core a48cd81.

It's 499032-th call to CompactMarshalBinary() that crashes, n.Value is not accessible.

Note: genesis-playback works, if --commit-every 1000 is passed.

[kostko]

This is very likely due to a bug in the leaf node unmarshaller:
https://github.com/oasislabs/oasis-core/blob/9e89921ae267e50d64c36131a213eb214aa34b40/go/storage/mkvs/urkel/node/node.go#L625

Currently it just references a slice of the data which is being unmarshalled. Since this is used when retrieving nodes from a memory mapped database (e.g., Badger), the slice may become invalid or be overwritten with other data.

Can you check if just fixing it to copy the value helps?

[matevz]

Works, thanks.

[matevz]

fixed