Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

go/oasis-node/cmd/debug/fixgenesis: Support migrating Node.Roles #2620

Merged
merged 1 commit into from
Jan 30, 2020

Conversation

Yawning
Copy link
Contributor

@Yawning Yawning commented Jan 30, 2020

The node.RolesMask bit definitons have changed since the last major
release deployed to the wild, so support migrating things by rewriting
the node descriptor.

Note: This assumes that signature validation in InitChain is disabled.

@Yawning Yawning added c:registry Category: entity/node/runtime registry service c:cli Category: command line interface labels Jan 30, 2020
@Yawning Yawning self-assigned this Jan 30, 2020
The node.RolesMask bit definitons have changed since the last major
release deployed to the wild, so support migrating things by rewriting
the node descriptor.

Note: This assumes that signature validation in InitChain is disabled.
@codecov
Copy link

codecov bot commented Jan 30, 2020

Codecov Report

Merging #2620 into master will decrease coverage by 0.14%.
The diff coverage is 0%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2620      +/-   ##
==========================================
- Coverage   63.32%   63.17%   -0.15%     
==========================================
  Files         360      360              
  Lines       33968    33972       +4     
==========================================
- Hits        21509    21462      -47     
- Misses       9822     9867      +45     
- Partials     2637     2643       +6
Impacted Files Coverage Δ
go/oasis-node/cmd/debug/fixgenesis/fixgenesis.go 8.53% <0%> (-0.44%) ⬇️
go/worker/common/host/interface.go 38.46% <0%> (-15.39%) ⬇️
go/consensus/api/grpc.go 57.02% <0%> (-6.62%) ⬇️
go/control/debug.go 67.74% <0%> (-6.46%) ⬇️
go/worker/common/host/protocol/protocol.go 65.67% <0%> (-2.99%) ⬇️
go/storage/metrics.go 73.21% <0%> (-2.68%) ⬇️
go/storage/mkvs/urkel/lookup.go 72.72% <0%> (-2.28%) ⬇️
go/worker/compute/txnscheduler/committee/node.go 62.02% <0%> (-2.22%) ⬇️
go/worker/common/p2p/p2p.go 68.46% <0%> (-1.81%) ⬇️
go/consensus/tendermint/tendermint.go 64.57% <0%> (-1.4%) ⬇️
... and 7 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4ba8186...b7942ef. Read the comment docs.

@Yawning Yawning merged commit 8b63486 into master Jan 30, 2020
@Yawning Yawning deleted the yawning/hack/node-flags branch January 30, 2020 10:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
c:cli Category: command line interface c:registry Category: entity/node/runtime registry service
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants