oasis-node/cmd/stake: Make info subcommand tolerate invalid thresholds #2632
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tjanez
requested review from
kostko,
peterjgilbert and
Yawning
as code owners
tjanez
force-pushed
the
tjanez/staking-thresholds
branch
2 times, most recently
from
36a78af
to
bcb5e8e
Compare
Codecov Report
@@ Coverage Diff @@
## master #2632 +/- ##
==========================================
+ Coverage 63.04% 63.29% +0.25%
==========================================
Files 360 360
Lines 34142 34153 +11
==========================================
+ Hits 21524 21617 +93
+ Misses 9966 9872 -94
- Partials 2652 2664 +12
Continue to review full report at Codecov.
|
tjanez
force-pushed
the
tjanez/staking-thresholds
branch
from
bcb5e8e
to
bd1490e
Compare
kostko
approved these changes
Jan 31, 2020
tjanez
commented
Jan 31, 2020
Comment on lines
+352
to
+359
| // Check that subcommand reported warnings for invalid staking threshold kinds. | ||
| subCmdOutput := b.String() | ||
| thresholdKinds := []string{"compute", "storage"} | ||
| for _, kind := range thresholdKinds { | ||
| if !strings.Contains(subCmdOutput, fmt.Sprintf("invalid staking threshold kind: %s", kind)) { | ||
| return fmt.Errorf("scenario/e2e/stake: querying common token info should warn about invalid staking threshold for kind: %s", kind) | ||
| } | ||
| } |
There was a problem hiding this comment.
I didn't know if this check is something we would want or is it testing a detail that is not important enough to be covered?
It replaces the ErrInvalidThreshold previously defined in go/consensus/tendermint/apps/staking.
Change the subcommand to print valid staking threshold kinds and warn about invalid ones. Add test for info subcommand to the stake-cli End-to-End test.
tjanez
force-pushed
the
tjanez/staking-thresholds
branch
from
bd1490e
to
255b2f8
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.