Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

send expected epoch along when calling SubmitTx #2650

Merged
merged 1 commit into from
Feb 14, 2020

Conversation

matevz
Copy link
Member

@matevz matevz commented Feb 6, 2020

PR for #1062:

  • runtime/client: add expectedEpochNumber parameter to SubmitTx call,
  • txnscheduler/committee/node: check whether expectedEpochNumber matches the local one,
  • executor/node, merge/node: abort, if state change detected,
  • e2e/multiple-runtimes:
    • reduce all group sizes to 1 with no backups,
    • use epochTime mock,
    • add new numComputeWorkers parameter,
  • cmd/node/node.go, common/commmittee/node.go, common/worker.go, runtime/client/client.go, worker/common/committee/group.go: access RootHash, Scheduler, Beacon, KeyManager, EpochTime, and Registry fields indirectly using consensus member.

@matevz matevz force-pushed the matevz/bug/submittx_epoch branch 3 times, most recently from e2016ad to 3df914c Compare February 7, 2020 12:22
go/worker/compute/txnscheduler/service.go Outdated Show resolved Hide resolved
go/runtime/client/client.go Outdated Show resolved Hide resolved
go/worker/compute/txnscheduler/committee/node.go Outdated Show resolved Hide resolved
go/worker/common/committee/group.go Outdated Show resolved Hide resolved
go/worker/common/committee/group.go Outdated Show resolved Hide resolved
go/runtime/client/client.go Outdated Show resolved Hide resolved
go/runtime/client/watcher.go Outdated Show resolved Hide resolved
go/runtime/client/watcher.go Outdated Show resolved Hide resolved
go/runtime/client/client.go Outdated Show resolved Hide resolved
@matevz matevz force-pushed the matevz/bug/submittx_epoch branch 2 times, most recently from e81c13b to 4f4e9a9 Compare February 12, 2020 13:07
@codecov
Copy link

codecov bot commented Feb 13, 2020

Codecov Report

Merging #2650 into master will decrease coverage by 0.06%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2650      +/-   ##
==========================================
- Coverage   62.90%   62.83%   -0.07%     
==========================================
  Files         370      370              
  Lines       34905    34910       +5     
==========================================
- Hits        21956    21936      -20     
- Misses      10177    10234      +57     
+ Partials     2772     2740      -32     
Impacted Files Coverage Δ
go/consensus/tendermint/api/api.go 73.58% <0.00%> (-15.10%) ⬇️
go/consensus/api/grpc.go 57.02% <0.00%> (-6.62%) ⬇️
go/worker/common/host/sandboxed.go 70.22% <0.00%> (-5.14%) ⬇️
.../consensus/tendermint/apps/epochtime_mock/state.go 84.61% <0.00%> (-5.13%) ⬇️
go/oasis-node/cmd/debug/byzantine/byzantine.go 35.01% <0.00%> (-5.04%) ⬇️
...o/consensus/tendermint/apps/scheduler/scheduler.go 71.70% <0.00%> (-3.03%) ⬇️
go/oasis-node/cmd/debug/byzantine/merge.go 74.68% <0.00%> (-2.54%) ⬇️
go/worker/common/p2p/p2p.go 66.21% <0.00%> (-1.36%) ⬇️
go/storage/client/client.go 73.47% <0.00%> (-0.87%) ⬇️
go/worker/registration/worker.go 66.66% <0.00%> (-0.50%) ⬇️
... and 19 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5aa8cea...005a1a3. Read the comment docs.

@matevz matevz marked this pull request as ready for review February 13, 2020 12:59
@matevz matevz force-pushed the matevz/bug/submittx_epoch branch 2 times, most recently from 0df5c05 to b16da6a Compare February 13, 2020 15:26
.changelog/2650.breaking.md Outdated Show resolved Hide resolved
.changelog/2650.internal.1.md Outdated Show resolved Hide resolved
.changelog/2650.internal.1.md Outdated Show resolved Hide resolved
.changelog/2650.internal.1.md Outdated Show resolved Hide resolved
.changelog/2650.internal.2.md Outdated Show resolved Hide resolved
Copy link
Member

@kostko kostko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Mostly looks good, some nits.

go/common/version/version.go Outdated Show resolved Hide resolved
go/oasis-node/cmd/node/node.go Show resolved Hide resolved
go/oasis-node/cmd/node/node.go Outdated Show resolved Hide resolved
go/runtime/client/client.go Outdated Show resolved Hide resolved
go/worker/compute/executor/committee/node.go Outdated Show resolved Hide resolved
go/worker/compute/executor/committee/node.go Outdated Show resolved Hide resolved
go/worker/compute/executor/committee/node.go Show resolved Hide resolved
go/worker/compute/merge/committee/node.go Outdated Show resolved Hide resolved
go/worker/compute/merge/committee/node.go Outdated Show resolved Hide resolved
go/worker/compute/txnscheduler/committee/node.go Outdated Show resolved Hide resolved
@matevz matevz force-pushed the matevz/bug/submittx_epoch branch 3 times, most recently from 71d53be to 2ff8e2a Compare February 14, 2020 12:51
@matevz matevz merged commit 7c800a8 into master Feb 14, 2020
@matevz matevz deleted the matevz/bug/submittx_epoch branch February 14, 2020 13:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants