Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add sanity checks for stake accumulator state integrity #2665

Merged
merged 2 commits into from
Feb 11, 2020

Conversation

kostko
Copy link
Member

@kostko kostko commented Feb 11, 2020

No description provided.

@kostko kostko added the c:testing Category: testing label Feb 11, 2020
@kostko kostko force-pushed the kostko/feature/stake-acc-sanity branch 2 times, most recently from 5675abe to d702263 Compare February 11, 2020 12:19
@kostko kostko force-pushed the kostko/feature/stake-acc-sanity branch from d702263 to d88d16b Compare February 11, 2020 12:38
@kostko kostko force-pushed the kostko/feature/stake-acc-sanity branch from d88d16b to 64ab925 Compare February 11, 2020 12:41
@codecov
Copy link

codecov bot commented Feb 11, 2020

Codecov Report

Merging #2665 into master will increase coverage by 0.07%.
The diff coverage is 55.2%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2665      +/-   ##
==========================================
+ Coverage   62.96%   63.04%   +0.07%     
==========================================
  Files         365      365              
  Lines       34504    34570      +66     
==========================================
+ Hits        21727    21795      +68     
+ Misses      10074    10066       -8     
- Partials     2703     2709       +6
Impacted Files Coverage Δ
go/staking/api/sanity_check.go 51.85% <0%> (-0.98%) ⬇️
go/consensus/tendermint/apps/registry/registry.go 64.81% <0%> (ø) ⬆️
...nt/apps/supplementarysanity/supplementarysanity.go 78.26% <100%> (+0.31%) ⬆️
go/consensus/tendermint/apps/staking/genesis.go 38.94% <16.66%> (-0.73%) ⬇️
...nsus/tendermint/apps/supplementarysanity/checks.go 48.79% <45.61%> (-1.67%) ⬇️
...consensus/tendermint/apps/registry/transactions.go 48.76% <66.66%> (-1.5%) ⬇️
go/registry/api/api.go 38.76% <91.3%> (+1.98%) ⬆️
go/runtime/committee/nodes.go 80.64% <0%> (-4.31%) ⬇️
go/roothash/tests/tester.go 95.54% <0%> (-0.64%) ⬇️
go/worker/compute/merge/committee/node.go 76.25% <0%> (-0.25%) ⬇️
... and 10 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a5172fb...64ab925. Read the comment docs.

@kostko kostko merged commit f4fc2c3 into master Feb 11, 2020
@kostko kostko deleted the kostko/feature/stake-acc-sanity branch February 11, 2020 13:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
c:testing Category: testing
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants